Conversation
There was a problem hiding this comment.
Pull request overview
This PR is a grab-bag of configuration and UI tweaks across the NixOS/Home Manager setup, primarily targeting Quickshell UX (brightness + notifications), Hyprland/Hyprpaper configuration, and developer/tooling packages.
Changes:
- Expanded Quickshell panel enablement and adjusted brightness control granularity/rate-limiting behavior.
- Improved notification icon rendering stability (cache + fallbacks) and adjusted some OSD/icon behavior.
- Refactored Hyprland config to Home Manager’s Hyprland module format, added/adjusted editor/tooling packages, and updated theme + lockfile inputs.
Reviewed changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/quickshell/shell-config.nix | Enables additional Quickshell panels via generated config JSON. |
| modules/quickshell/config/services/Brightness.qml | Tweaks brightness step size and rewrites sync/cooldown execution logic. |
| modules/quickshell/config/modules/ii/sidebarRight/QuickSliders.qml | Adds finer slider stepping for brightness. |
| modules/quickshell/config/modules/ii/onScreenDisplay/indicators/BrightnessIndicator.qml | Disables rotate/scale icon effects for brightness OSD. |
| modules/quickshell/config/modules/ii/bar/BarContent.qml | Adjusts brightness scroll step size on the bar. |
| modules/quickshell/config/modules/common/widgets/NotificationAppIcon.qml | Caches icon inputs and adds robust fallbacks for missing icons/images. |
| modules/hyprland/hyprpaper.nix | Changes Hyprpaper wallpaper configuration format and fit mode. |
| modules/hyprland/hyprland-config.nix | Migrates Hyprland config to wayland.windowManager.hyprland.settings. |
| modules/home-manager/vscode.nix | Removes Python extension from the general VS Code extensions list. |
| modules/home-manager/security-tools.nix | Adds a new Home Manager module for security/network tooling packages. |
| modules/home-manager/rust.nix | Adds Rust analyzer VS Code extension. |
| modules/home-manager/python.nix | Expands Python env with lint/format/type tools and adds Python VS Code extension. |
| modules/home-manager/neovim.nix | Updates Neovim plugin naming and Lua config option name. |
| modules/home-manager/jetbrains.nix | Adds _JAVA_AWT_WM_NONREPARENTING=1 for JetBrains under Wayland. |
| modules/home-manager/haskell.nix | Adds a new Home Manager module for Haskell tooling and VS Code extension. |
| modules/home-manager/discord.nix | Renames/adjusts a Nixcord plugin key. |
| modules/home-manager/cli-tools.nix | Swaps neofetch for fastfetch. |
| modules/home-manager/basics.nix | Switches Thunar/tumbler package references and sets GTK4 theme from GTK theme. |
| hosts/centaur/home.nix | Updates imported Home Manager modules (python/haskell/security-tools). |
| hosts/centaur/configuration.nix | Adjusts greetd command, enables Wireshark, and tweaks package references/groups. |
| flake.nix | Switches the active theme to dracula. |
| flake.lock | Updates pinned inputs (Hyprland ecosystem, stylix, nixpkgs, etc.). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "--sessions ${waylandSessions}:${xSessions}" | ||
| "--time" | ||
| "--cmd Hyprland" | ||
| "--cmd start-hyprland" |
| const monitor = monitors.find(m => focusedName === m.screen.name); | ||
| if (monitor) | ||
| monitor.setBrightness(monitor.brightness + 0.05); | ||
| monitor.setBrightness(monitor.brightness + 0.01); // Changed from 0.05 to 0.01 |
| const monitor = monitors.find(m => focusedName === m.screen.name); | ||
| if (monitor) | ||
| monitor.setBrightness(monitor.brightness - 0.05); | ||
| monitor.setBrightness(monitor.brightness - 0.01); // Changed from 0.05 to 0.01 |
Comment on lines
126
to
+130
| // Shorter delay for more responsive brightness changes | ||
| property bool pendingSync: false | ||
| property var setTimer: Timer { | ||
| id: setTimer | ||
| interval: monitor.isDdc ? 300 : 50 | ||
| interval: 100 |
Comment on lines
+91
to
+94
| "iiPolkit" | ||
| "iiRegionSelector" | ||
| "iiReloadPopup" | ||
| "iiScreenCorners" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.