This repository was archived by the owner on Mar 17, 2025. It is now read-only.
Optimize our $bindTo code base #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround for #133 - can't change $priority or $value in $bindTo (they are now stored as _id, _value, and _priority, which trigger updates for $watch)
|
This required a bigger fix than expected, but I think it looks good. I'm impressed you wrote your own |
Contributor
Author
|
@davideast This isn't ready to merge yet. I'm having some issues with the e2e tests and Travis is failing. I couldn't resolve these tonight. I'll look at it again tomorrow. |
Contributor
Author
|
@davideast this is now ready to merge cc @jacobawenger |
|
Changes Unknown when pulling 0649a94 on kato-403 into * on master*. |
davideast
added a commit
that referenced
this pull request
Aug 28, 2014
Optimize our $bindTo code base
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@davideast please review cc @jacobawenger
Improves but does not fixFixes #400! - $bindTo not working with inputsWorkaround for #133 - can't change $priority or $value in $bindTo (they are now stored as _id, _value, and _priority, which trigger updates for $watch)