This repository was archived by the owner on Mar 17, 2025. It is now read-only.
Fixed bug from calling $logout() multiple times #433
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@katowulf - This fixes #431. We used to set
this._currentUserDatatoundefinedevery time$logout()was called. This worked in most cases since the called tothis._authClient.logout()ended up firing out_onLoginEvent()callback which setthis._currentUserDatatonulland resolved any leftovergetCurrentUser()promises. However, if we calledthis._authClient.logout()when we were already logged out, Simple Login does not fire the_onLoginEvent()callback andthis._currentUserDatagets stuck asundefined, which causes problems for logging in and getting the current user. Havingthis._currentUserDataasundefinedshould only be valid at the very initializing of this service. It should always otherwise benullor a valid user object. As a result, this change just sets it tonullwhen we call$logout().cc/ @davideast