Skip to content

Conversation

@leoortizz
Copy link
Contributor

#92 allowed Firebase ^10.0.0, but 10.1.0 errors out as it doesn't match the expected version.

I changed it to >=9.9.0, as 9.9.0 was the version defined before #92

@jhuleatt
Copy link
Collaborator

^10.0.0 should include 10.1.0 per the npm semver calculator. Is something else going on that is causing this?

@jhuleatt
Copy link
Collaborator

Oh, I think the issue is just that we never released it

@leoortizz
Copy link
Contributor Author

Oh, I think the issue is just that we never released it

oh, might be it! I have not checked which version was being used when I had the error.

@leoortizz
Copy link
Contributor Author

@jhuleatt @alexastrum closing this PR as the real issue is that #92 was merged but was never released to NPM, so people still having the peer dependency issue with firebase >= 10.

@leoortizz leoortizz closed this Aug 31, 2023
@leoortizz leoortizz deleted the leoortizz_firebase-peer-dep branch September 5, 2023 19:08
@GeoloeG-IsT
Copy link

it is not fixed yet...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants