(feat) add Firestore SSR features to nightly tests #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlarocque
approved these changes
Jun 30, 2025
DellaBitta
changed the title
DellaBitta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Updates:
Updates the CI to test against Firebase Next and not Firebase Canary. The Canary target installs the Canary of the previously released version, where as Next installs the upcoming version (which we should test against).
Unfreezes the yarn lock file so that CI installs the latest Next version as it becomes available.
Additions to the test framework:
Expands upon Firestore tests to ensure that.
toJsonandfromJsonworks for:BytesDocumentSnapshotGeoPointQuerySnapshotTimestampVectorValueAdditionally tests that these object type can be serialized server-side then deserialized client-side and their values matched the originals.
Finally, also tests that QuerySnapshot and DocumentSnapshot can be stood up as listeners form their serialized forms.