Skip to content

(feat) add Firestore SSR features to nightly tests #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 30, 2025
Merged

(feat) add Firestore SSR features to nightly tests #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7141753
Add bundle creation and parsing tests on server.
DellaBitta Jun 24, 2025
b4c82ba
csr test runner passes isServer false
DellaBitta Jun 24, 2025
db6d2b2
tracer bundle tests work manually
DellaBitta Jun 25, 2025
4dd23c6
fixes for playwright browser tests
DellaBitta Jun 26, 2025
3bd4cff
All working, needs refactor.
DellaBitta Jun 26, 2025
28711d2
Refactored tests.
DellaBitta Jun 26, 2025
6f7d557
Final proof
DellaBitta Jun 30, 2025
07cbb54
Package updates
DellaBitta Jun 30, 2025
1d82503
unfreeze lock file in workflow
DellaBitta Jun 30, 2025
9ce94c2
Merge branch 'main' into firestore-ssr-tests
DellaBitta Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions app/tests/firestore/web_client/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,21 @@
*/
import type { Metadata } from 'next'
import CSRTestRunner from '@/components/app_tests/firestore/csr_test_runner';
import {
buildSerializedFirestoreData,
SerializedFirestoreData
} from '@/lib/app_tests/firestore/test';

export const metadata: Metadata = {
title: 'Firestore Web SDK CSR test'
}

export default function Page() {
export default async function Page() {
const serializedFirestoreData : SerializedFirestoreData = await buildSerializedFirestoreData();
return (
<>
<h1>Firestore CSR Test results:</h1>
<CSRTestRunner />
<CSRTestRunner serializedFirestoreData={serializedFirestoreData} />
</>
);
}
2 changes: 1 addition & 1 deletion app/tests/firestore/web_ssr/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const metadata: Metadata = {
}

export default async function Page() {
const testResults: TestResults = await testFirestore();
const testResults: TestResults = await testFirestore(/* isServer= */ true);
return (
<>
<h1>Firestore SSR Test results:</h1>
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"test": "playwright test"
},
"dependencies": {
"firebase": "canary",
"firebase": "next",
"next": "latest",
"react": "latest",
"react-dom": "latest"
Expand Down
13 changes: 9 additions & 4 deletions src/components/app_tests/firestore/csr_test_runner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,22 +17,27 @@
'use client'

import { useState, useEffect } from 'react'
import { testFirestore, initializeTestResults } from '@/lib/app_tests/firestore/test';
import {
initializeTestResults,
testSerializedFirestoreData,
testFirestore } from '@/lib/app_tests/firestore/test';
import ResultsDisplay from './results_display';

export default function CsrTestRunner() {
export default function CsrTestRunner(props) {
const [testStatus, setTestStatus] = useState<string>("running...");
const [testResults, setTestResults] = useState(initializeTestResults());
useEffect(() => {
const asyncTest = async () => {
setTestResults(await testFirestore());
let testResults = await testFirestore(/* isServer= */ false);
testResults = await testSerializedFirestoreData(testResults, props.serializedFirestoreData);
setTestResults(testResults);
setTestStatus("Complete!");
}
asyncTest().catch((e) => {
console.error("Error encountered during testing: ", e);
setTestStatus("Errored!");
});
}, []);
}, [props.serializedFirestoreData]);

return (
<ResultsDisplay statusString={testStatus} testResults={testResults} />
Expand Down
18 changes: 18 additions & 0 deletions src/components/app_tests/firestore/results_display.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,28 @@ export default function ResultsDisplay({ statusString, testResults }) {
<h4 title="updateDocResult">updateDocResult: {testResults.updateDocResult}</h4>
<h4 title="onSnapshotUpdateDR">onSnapshotUpdateDocResult: {testResults.onSnapshotUpdateDocResult}</h4>
<h4 title="getDocResult">getDocResult: {testResults.getDocResult}</h4>
<h4 title="querySnapshotGetDocsResult">querySnapshotGetDocsResult: {testResults.querySnapshotGetDocsResult}</h4>
<h4 title="documentSnapshotBundleResult">documentSnapshotBundleResult: {testResults.documentSnapshotBundleResult}</h4>
<h4 title="reconstitutedDocDataResult">reconstitutedDocDataResult: {testResults.reconstitutedDocDataResult}</h4>
<h4 title="documentSnapshotOnSnapshotResumeResult">documentSnapshotOnSnapshotResumeResult: {testResults.documentSnapshotOnSnapshotResumeResult}</h4>
<h4 title="querySnapshotOnSnapshotResumeResult">querySnapshotOnSnapshotResumeResult: {testResults.querySnapshotOnSnapshotResumeResult}</h4>
<h4 title="querySnapshotBundleResult">querySnapshotBundleResult: {testResults.querySnapshotBundleResult}</h4>
<h4 title="reconstitutedQueryDataResult">reconstitutedQueryDataResult: {testResults.reconstitutedQueryDataResult}</h4>
<h4 title="deleteDocResult">deleteDocResult: {testResults.deleteDocResult}</h4>
<h4 title="onSnapshotDeleteDR">onSnapshotDeleteDocResult: {testResults.onSnapshotDeleteDocResult}</h4>
<h4 title="getDeletedDocResult">getDeletedDocResult: {testResults.getDeletedDocResult}</h4>
<h4 title="deleteAppResult">deleteAppResult: {testResults.deleteAppResult}</h4>

<h3> CSR-side deserialization tests </h3>
<h4 title="csrDocumentSnapshotResult">csrDocumentSnapshotResult: {testResults.csrDocumentSnapshotResult}</h4>
<h4 title="csrDocumentSnapshotOnResumeResult">csrDocumentSnapshotOnResumeResult: {testResults.csrDocumentSnapshotOnResumeResult}</h4>
<h4 title="csrQuerySnapshotResult">csrQuerySnapshotResult: {testResults.csrQuerySnapshotResult}</h4>
<h4 title="csrQuerySnapshotOnResumeResult">csrQuerySnapshotOnResumeResult: {testResults.csrQuerySnapshotOnResumeResult}</h4>
<h4 title="csrDeserializedBytesResult">csrDeserializedBytesResult: {testResults.csrDeserializedBytesResult}</h4>
<h4 title="csrDeserializedGeoPointResult">csrDeserializedGeoPointResult: {testResults.csrDeserializedGeoPointResult}</h4>
<h4 title="csrDeserializedTimestampResult">csrDeserializedTimestampResult: {testResults.csrDeserializedTimestampResult}</h4>
<h4 title="csrDeserializedVectorValueResult">csrDeserializedVectorValueResult: {testResults.csrDeserializedVectorValueResult}</h4>

<p />
<Link href="/">Back to test index</Link>
</>
Expand Down
Loading