Scan a file for its function and constant declarations - #393
Open
Firehed wants to merge 10 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
============================================
+ Coverage 98.58% 98.59% +0.01%
- Complexity 1758 1774 +16
============================================
Files 116 119 +3
Lines 4451 4488 +37
============================================
+ Hits 4388 4425 +37
Misses 63 63 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice S3.7b (#390).
DeclarationScannerreads the functions and constants a parsedfile declares, so S3.7d can derive a name→file index for the two symbol namespaces
Composer cannot address by name.
namespacedName(set byNameResolverduringParserService::parse()), not hand-trackedStmt\Namespace_— the shape SC.3 isremoving elsewhere.
const,literal
define()in any casing, and declarations nested in a conditional (the polyfillshape, which a top-level-only walk would drop).
define()name, andanything reached only through a
require/include.QualifiedNamelands here rather than in S3.7c as the manifest said — the scanner is itsfirst caller. Manifest corrected in this branch;
fromClassName()is left for S3.7c,where
FilesystemBackendneeds it.