3.3.7
Turns out the fix in 3.3.6 and the dynamic-theme compatibility from issue #5 couldn't stand in the same room: any theme extension quietly switched the square corners back off. Found once again by reddit user NeroWolfe_ – with Adaptive Tab Bar Colour active, every popup went round again.
Fixed
- Square popup corners now survive dynamic theme extensions (Adaptive Tab Bar Colour, or any add-on using the theme API). All of FoxOne's shape rules – the radius tokens and the 3.3.6 Mica opt-out – lived inside the
:root:not([lwtheme])scope that issue #5 introduced to yield FoxOne's colours to a running theme. Since a theme extension setslwthemeon the root, it disabled the corner logic wholesale. Shape is FoxOne identity, not colour: the radius tokens and the Mica opt-out now apply unconditionally, while frame, toolbar, URL bar and popup surfaces keep following the theme exactly as before. - Context menus no longer render see-through under a dynamic theme. Firefox's Mica branch empties the popup background at element level (the native backdrop was meant to paint it); FoxOne's own surface rule used to cover that hole, but it steps back when a theme is active. The Mica opt-out now restores the background from the root, where the theme's popup colour lives – with FoxOne's base as fallback for themes that don't define one.
- The accent-text hover (amber text instead of a highlight block, issue #16) now works in context menus and panels regardless of an active theme. It sat in the same lwtheme scope, so themed setups got the native grey highlight block instead.
Thanks to NeroWolfe_ for the find and the clean repro. Great job!