UseLocalSpace missing from non-threaded MovementSettings

[maxkratt]

Unity version:

Unity 6000.3

FishNet version:

FishNet 4.6.21

Discord link:

https://discord.com/channels/424284635074134018/1034477094731784302/1473459192445669502

Description:

The UseLocalSpace variable does not exist in the non-threaded MovementSettings.cs file and causes errors in the Unity editor when opening the dropdowns in NetworkTickSmoother.

Replication:

1. Open a project with FishNet 4.6.21.
2. Disable the Threaded TickSmoothers.
3. Add a NetworkTickSmoother to an object and open its dropdowns.
4. See the following errors:

NullReferenceException: Use Local Space: SerializedProperty is null
UnityEditor.EditorGUI.BeginPropertyInternal (UnityEngine.Rect totalPosition, UnityEngine.GUIContent label, UnityEditor.SerializedProperty property) (at <0e78d59907e9464abb64cd241282731e>:0)
UnityEditor.EditorGUI.DefaultPropertyField (UnityEngine.Rect position, UnityEditor.SerializedProperty property, UnityEngine.GUIContent label) (at <0e78d59907e9464abb64cd241282731e>:0)
UnityEditor.PropertyHandler.OnGUI (UnityEngine.Rect position, UnityEditor.SerializedProperty property, UnityEngine.GUIContent label, System.Boolean includeChildren, UnityEngine.Rect visibleArea) (at <0e78d59907e9464abb64cd241282731e>:0)
UnityEditor.PropertyHandler.OnGUI (UnityEngine.Rect position, UnityEditor.SerializedProperty property, UnityEngine.GUIContent label, System.Boolean includeChildren) (at <0e78d59907e9464abb64cd241282731e>:0)
UnityEditor.EditorGUI.PropertyFieldInternal (UnityEngine.Rect position, UnityEditor.SerializedProperty property, UnityEngine.GUIContent label, System.Boolean includeChildren) (at <0e78d59907e9464abb64cd241282731e>:0)
UnityEditor.EditorGUI.PropertyField (UnityEngine.Rect position, UnityEditor.SerializedProperty property, UnityEngine.GUIContent label, System.Boolean includeChildren) (at <0e78d59907e9464abb64cd241282731e>:0)
UnityEditor.EditorGUI.PropertyField (UnityEngine.Rect position, UnityEditor.SerializedProperty property, UnityEngine.GUIContent label) (at <0e78d59907e9464abb64cd241282731e>:0)
GameKit.Dependencies.Utilities.PropertyDrawerTool.DrawProperty (UnityEditor.SerializedProperty prop, UnityEngine.GUIContent content, UnityEngine.FontStyle labelStyle, System.Int32 indent) (at Assets/FishNet/Runtime/Plugins/GameKit/Dependencies/Utilities/EditorTools.cs:269)
GameKit.Dependencies.Utilities.PropertyDrawerTool.DrawProperty (UnityEditor.SerializedProperty prop, System.String label) (at Assets/FishNet/Runtime/Plugins/GameKit/Dependencies/Utilities/EditorTools.cs:220)
FishNet.Component.Transforming.Beta.Editing.MovementSettingsDrawer.OnGUI (UnityEngine.Rect position, UnityEditor.SerializedProperty property, UnityEngine.GUIContent label) (at Assets/FishNet/Runtime/Generated/Component/TickSmoothing/Editor/MovementSettingsDrawer.cs:41)
UnityEditor.PropertyDrawer.OnGUISafe (UnityEngine.Rect position, UnityEditor.SerializedProperty property, UnityEngine.GUIContent label) (at <0e78d59907e9464abb64cd241282731e>:0)
UnityEditor.PropertyHandler.OnGUI (UnityEngine.Rect position, UnityEditor.SerializedProperty property, UnityEngine.GUIContent label, System.Boolean includeChildren, UnityEngine.Rect visibleArea) (at <0e78d59907e9464abb64cd241282731e>:0)
UnityEditor.PropertyHandler.OnGUI (UnityEngine.Rect position, UnityEditor.SerializedProperty property, UnityEngine.GUIContent label, System.Boolean includeChildren) (at <0e78d59907e9464abb64cd241282731e>:0)
UnityEditor.PropertyHandler.OnGUILayout (UnityEditor.SerializedProperty property, UnityEngine.GUIContent label, System.Boolean includeChildren, UnityEngine.GUILayoutOption[] options) (at <0e78d59907e9464abb64cd241282731e>:0)
UnityEditor.EditorGUILayout.PropertyField (UnityEditor.SerializedProperty property, UnityEngine.GUIContent label, System.Boolean includeChildren, UnityEngine.GUILayoutOption[] options) (at <0e78d59907e9464abb64cd241282731e>:0)
UnityEditor.EditorGUILayout.PropertyField (UnityEditor.SerializedProperty property, UnityEngine.GUILayoutOption[] options) (at <0e78d59907e9464abb64cd241282731e>:0)
FishNet.Component.Transforming.Beta.NetworkTickSmootherEditor.OnInspectorGUI () (at Assets/FishNet/Runtime/Generated/Component/TickSmoothing/Editor/NetworkTickSmootherEditor.cs:40)
UnityEditor.UIElements.InspectorElement+<>c__DisplayClass82_0.<CreateInspectorElementUsingIMGUI>b__2 () (at <0e78d59907e9464abb64cd241282731e>:0)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr, Boolean&)

Expectation:

No errors.

Note

Thanks to Toblet for finding and reporting this.

[FirstGearGames]

Resolved in 4.6.22.

Resolution:

• open MovementSettingsDrawer.cs
  Delete lines...

            _propertyDrawer.DrawProperty(useLocalSpace, "Use Local Space");
         SerializedProperty useLocalSpace = property.FindPropertyRelative("UseLocalSpace");