Fixed NetworkAnimator not always deinitializing properly when an object was unexpectedly destroyed.#550
Merged
FirstGearGames merged 1 commit intoNov 14, 2023
Conversation
…ct was unexpectedly destroyed.
Owner
|
Looks good, ty! |
FirstGearGames
added a commit
that referenced
this pull request
Nov 16, 2023
- Improved Tugboat.GetPort returns active port after server is started in the scenario listening port is set to 0. - Fixed rare cases of Awake not calling on parent with multiple inheritence levels. - Fixed connections getting duplicate entries in SyncList when values were added on the same tick for connection, before spawn was written. (#505) - Fixed Demos/SceneManager/Additive Scenes/AdditiveScenes_Start missing references. - Fixed NetworkAnimatorEditor not dirtying synchronized parameters when changed inside a prefab. - Fixed NetworkAnimator not always unsubscribing from TimeManager on destroy. (#550) - Added CliemtManager.OnClientTimeOut. - Added ClientManager.LastPacketLocalTick. - Fixed typo in IntermediateLayer.HandleOutgoing method name.
FirstGearGames
pushed a commit
that referenced
this pull request
Nov 21, 2023
- Improved Tugboat.GetPort returns active port after server is started in the scenario listening port is set to 0. - Fixed rare cases of Awake not calling on parent with multiple inheritence levels. - Fixed connections getting duplicate entries in SyncList when values were added on the same tick for connection, before spawn was written. (#505) - Fixed Demos/SceneManager/Additive Scenes/AdditiveScenes_Start missing references. - Fixed NetworkAnimatorEditor not dirtying synchronized parameters when changed inside a prefab. - Fixed NetworkAnimator not always unsubscribing from TimeManager on destroy. (#550) - Added CliemtManager.OnClientTimeOut. - Added ClientManager.LastPacketLocalTick. - Fixed typo in IntermediateLayer.HandleOutgoing method name. - Improved average rollback accuracy by roughly 0.012m. - Improved PredictedObject now warns when trying to use Rigidbody as prediction type while rigidbodies are kinematic. - Changed removed ObserverCondition Clone() and Timed(). - Improved Tugboat.GetPort returns active port after server is started in the scenario listening port is set to 0. - Fixed NetworkTransform.ForceSend not force sending when transform properties were default. - Added NetworkTransform.ForceSend(uint) to force send after a delay. - Fixed several instances of client handling incoming data on despawned objects resulting in harmless warnings. - Improved codegen for Awake initialization to be more reliable and provide better feedback during errors. - Fixed OnClientTimeout not invoking. - Added V3 to V4 upgrade helper menu. - Added code generation to catch mistakes in converting SyncVars from v3 to v4. - Fixed nested objects corrupting spawn packets. (#543) (#542) - Added TimeManager.GetTickAsDouble(byte), GetTickPercentAsByte(byte), GetTickPercentAsDouble(). - Removed TimeManager.GetTickPercent(), replaced with GetTickPercentAsByte().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically the same thing that was done to NetworkTransform in 3.11.5.
We've been getting a lot of error reports that include:
I assume the null ref here refers to TimeManager and hopefully this will fix it.