Avoid calling prevTd.Update() twice#655
Merged
FirstGearGames merged 1 commit intoFirstGearGames:mainfrom Apr 23, 2024
Merged
Conversation
We're calling it again below after potentially modifying nextTd
Owner
|
Added in 4.2.1, ty! |
FirstGearGames
pushed a commit
that referenced
this pull request
Apr 23, 2024
- Changed exposed NetworkTransform.ParentBehaviour. - Changed TimeManager.AllowTickDropping default to true. - Changed TimeManager.MaximumFrameTicks default from 2 to 3. - Fixed removed debug from SyncDictionary. - Improved XML on NetworkCollider/2D. - Added AdditionalSize to all NetworkCollider/2D components. - Improved Yak will no longer show as a missing script when importing FishNet Free over Pro. - Improved removed code analysis warnings for Yak and ColliderRollback when importing FishNet Free over Pro. - Changed several consts names which indicated byte length from _BYTES to _LENGTH. - Fixed NetworkTransform not synchronizing parents properly. - Fixed prediction buffer running a varying amount of ReplayedCreated states per reconcile. - Changed removed TimeManager Time.fixedDeltaTime change warning in favor of displaying information on component inspector. - Changed TimeManager.AllowTickDropping now applies to server and client, previously client only. - Changed renamed PredictionManager.QueuedInputs to Interpolation; description updated. - Improved TimeManager.Tick accuracy significantly to always be within 1 tick or better. - Improved client timing. - Improved ColliderRollback average accuracy by approximately 0.015f. - Improved updated Edgegap plugin to commit b721722. - Added NetworkObject.GetGraphicalObject/SetGraphicalObject. - Improved exposed DefaultObjectPool.GetOrCreateCache. - Fixed SyncList enumerator not returning generic type (#657). - Fixed SyncVar initial values not applying when being set within Awake (#657). - Fixed CreateReconcile override detection failing when overriding multiple times in an inheritance chain (#646). - Fixed NetworkTransform incorrectly calling a method twice (#655). - Improved prediction interpolation and corrections significantly for owned and spectated objects. - Removed prediction development demos while they are reworked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're calling it again below after potentially modifying nextTd
This doesn't change any behavior, was just trying to fix some issues we're seeing with interpolation and noticed this no-op call.