chore(security): override brace-expansion to fix the failing audit - #1461
Conversation
A new advisory (GHSA-mh99-v99m-4gvg, high) flags brace-expansion <= 5.0.7 with the only patched release being 5.0.8. The scheduled Security workflow has failed on every run since 2026-07-27. pnpm audit --fix adds a scoped override in both the root and website packages; the lockfile diffs touch only brace-expansion and its subtree. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds matching ChangesDependency Configuration
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying openspec-docs with
|
| Latest commit: |
39d71d1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d2280d9c.openspec-docs.pages.dev |
| Branch Preview URL: | https://chore-brace-expansion-audit.openspec-docs.pages.dev |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@flake.nix`:
- Line 54: Replace the empty hash assigned to pnpmDeps.hash with the concrete
sha256 value generated by running scripts/update-flake.sh after the lockfile
changes, then commit the updated hash so the fixed-output derivation builds
successfully.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 1e6153e5-2d5f-4e07-be8b-16e0b29ae40f
📒 Files selected for processing (1)
flake.nix
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
alfred-openspec
left a comment
There was a problem hiding this comment.
Reviewed at b3d39fc. Both audits are clean, the root and website builds pass, the Nix hash is green, the cross-platform 2,279-test CI suite passes, and I verified the affected serve out preview returns both the homepage and a docs route successfully.
Status: ready to merge — audits clean, website builds, all 2,279 tests pass.
What was wrong: The Security workflow has failed on every run on
mainsince 2026-07-27. A new advisory (GHSA-mh99-v99m-4gvg, high severity) flagsbrace-expansion <= 5.0.7, and both lockfiles resolve a vulnerable version:5.0.7at the root and1.1.16inwebsite/(viaminimatch@3, which pins^1.1.7— the only patched release is5.0.8, so a plain update can't reach it).How it was fixed: Ran
pnpm audit --fixin both packages. It adds a scoped override,"brace-expansion@<=5.0.7": ">=5.0.8", to eachpackage.json(next to the existing postcss/sharp overrides inwebsite/). The lockfile diffs touch only brace-expansion and its own subtree. No change to the audit workflow — it caught a real advisory.Proof:
pnpm audit --audit-level high --dir websiteexits 1 (same failure as the Security run on main).pnpm audit --audit-level highandpnpm audit --audit-level high --dir websiteprintNo known vulnerabilities found.pnpm --dir website buildsucceeds; rootpnpm build+vitest runpass (112 files, 2,279 tests).Notes: The forced 1.x → 5.x jump in
website/only affectsserve-handler(theserve outpreview script; not part of the Next build). brace-expansion 5.x changed its export shape, so brace patterns like{a,b}in serve-handler globs would break — we useservewith no config, so no such patterns exist. The override can be dropped onceminimatch/servemove off the 1.x line.🤖 Generated with Claude Code
Summary by CodeRabbit
brace-expansionversion is selected.brace-expansionversion resolution safeguard to the website package configuration.