Conversation
Covers the case where a segment IN condition's string value starts with "[" and ends with "]" but is not valid JSON — the engine should fall back to splitting on commas rather than erroring out. beep boop
khvn26
added a commit
to Flagsmith/flagsmith-engine
that referenced
this pull request
Apr 24, 2026
HEAD Temporary pin so CI can run against the bracketed-invalid-JSON CSV fallback test case that covers the new `except ValueError` branch in `_parse_in_values_str`. Will be bumped to the next release tag once Flagsmith/engine-test-data#50 merges. beep boop
gagantrivedi
approved these changes
Apr 24, 2026
khvn26
added a commit
to Flagsmith/flagsmith-engine
that referenced
this pull request
Apr 24, 2026
Moves the submodule off the temporary PR-branch pin to the tagged release that includes the bracketed-invalid-JSON CSV fallback test case (Flagsmith/engine-test-data#50). beep boop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to Flagsmith/flagsmith-python-client#198
"[foo,bar]") but isn't valid JSON."[foo"matches one of the CSV tokens.