ci: Use manual releases, check version bump only when releasing #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Confirmed that this PR works without requiring a version bump, so that's progress - still need to test the release workflow. |
matthewelwell
approved these changes
Feb 11, 2025
Contributor
matthewelwell
left a comment
matthewelwell
left a comment
There was a problem hiding this comment.
Looks good to me. I don't see a reason not to yolo merge and test after?
Contributor
Author
|
We can - none of this affects any published artifacts so I'll merge it now. Thanks for the review! |
This was referenced Feb 20, 2025
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not yet tested.
Makes releasing a manual operation. Remove version bump checks on PRs, and only enforce them on release by running the same lint workflow as part of the release.