Skip to content

feat: Add API and Frontend PDB#518

Merged
germangarces merged 7 commits intomainfrom
add-api-frontend-pdb
Apr 1, 2026
Merged

feat: Add API and Frontend PDB#518
germangarces merged 7 commits intomainfrom
add-api-frontend-pdb

Conversation

@germangarces
Copy link
Copy Markdown
Contributor

@germangarces germangarces commented Apr 1, 2026 •
edited
Loading

Summary

Adds PodDisruptionBudget resources for API and Frontend services.

Based on #371 by @dapama, with the following improvements:

  • Added standard metadata labels (matching deployment patterns)
  • Fixed maxUnavailable/minAvailable logic to use hasKey checks (handles maxUnavailable: 0 correctly)

Test plan

  • helm template with pdb.api.enabled=true renders correctly
  • helm template with pdb.frontend.enabled=true renders correctly
  • helm lint passes
  • CI lint-test passes

@germangarces germangarces mentioned this pull request Apr 1, 2026
Closed
khvn26
khvn26 approved these changes Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@germangarces germangarces enabled auto-merge (squash) April 1, 2026 11:16
@germangarces germangarces disabled auto-merge April 1, 2026 11:17
@germangarces germangarces merged commit 2784516 into main Apr 1, 2026
2 checks passed
@germangarces germangarces deleted the add-api-frontend-pdb branch April 1, 2026 11:39
@flagsmithdev flagsmithdev mentioned this pull request Apr 1, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khvn26 khvn26 khvn26 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@germangarces @khvn26 @dapama