feat(task-processor): Add task_type label to task processor metrics
#51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
approved these changes
Apr 14, 2025
Contributor
matthewelwell
left a comment
matthewelwell
left a comment
There was a problem hiding this comment.
Approved with a minor suggestion.
| ) -> None: | ||
| # Given | ||
| @register_recurring_task(run_every=timedelta(milliseconds=200)) | ||
| def _dummy_recurring_task() -> None: |
Contributor
There was a problem hiding this comment.
Something that I picked up from Zach, that we should use _fake_recurring_task here for political correctness :)
I'm sure there are other occurrences of 'dummy' in the codebase, and I'm not suggesting we go and retrospectively correct them all now, but let's not make the debt worse.
This was referenced Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.