fix(traits/float_value): Add custom field to ser/deser trait_value#114
Merged
gagantrivedi merged 2 commits intorelease/2.0.2from Apr 25, 2022
Merged
Conversation
Since dynamodb can't understand float(and trait value can be float) we need to convert it to Decimal in order to store that in dynamodb
matthewelwell
approved these changes
Apr 25, 2022
gagantrivedi
added a commit
that referenced
this pull request
Apr 25, 2022
* Release 2.0.2 * fix(traits/float_value): Add custom field to ser/deser trait_value (#114) * fix(traits/float_value): Add custom field to ser/deser trait_value Since dynamodb can't understand float(and trait value can be float) we need to convert it to Decimal in order to store that in dynamodb * minor review fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since dynamodb can't understand float(and trait value can be float)
we need to convert it to Decimal in order to store that in dynamodb