Skip to content

fix: CI lint silently breaks whenever a new Go stable is released#207

Merged
gagantrivedi merged 2 commits intomainfrom
fix/lint-go-version-drift
Apr 29, 2026
Merged

fix: CI lint silently breaks whenever a new Go stable is released#207
gagantrivedi merged 2 commits intomainfrom
fix/lint-go-version-drift

Conversation

@emyller
Copy link
Copy Markdown
Contributor

@emyller emyller commented Apr 28, 2026

Every pull request opened on this repository today fails the lint stage with errors unrelated to the change under review, because the bundled type-checker is built against the Go 1.24 standard library while the workflow runs on stable, which advanced to Go 1.26 with its February 2026 release. The break is pure toolchain drift; the source code is otherwise clean. Restoring CI requires moving the lint action to its v8+ line, which in turn requires migrating the lint configuration to the golangci-lint v2 schema. Going to v2 also drops the bundled suppressions v1 inherited by default, surfacing two findings the project had been silently hiding — both addressed inline rather than re-suppressed.

Changes

  • Pull requests that touch no CI configuration pass the lint stage on the most recent released Go.
  • Lint findings previously hidden by the toolchain's default suppressions are made explicit in source.
  • Future automated bumps to the lint action land cleanly because the configuration matches current upstream conventions.

Closes #206

Review effort: 2/5

emyller and others added 2 commits April 28, 2026 19:32
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@emyller emyller requested a review from a team as a code owner April 28, 2026 22:33
@emyller emyller requested review from gagantrivedi and removed request for a team April 28, 2026 22:33
@gagantrivedi gagantrivedi merged commit d407307 into main Apr 29, 2026
4 checks passed
@emyller emyller deleted the fix/lint-go-version-drift branch April 29, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI lint silently breaks whenever a new Go stable is released

2 participants