Keep a record of the last fetched flags and only emit a new value if it's changed#77
Merged
matthewelwell merged 7 commits intoFlagsmith:mainfrom Jul 18, 2025
Conversation
Co-authored-by: Matthew Elwell <mjelwell89@gmail.com>
…t 5. Hopefully this fixes the build issues.
…thub.com/foresightmobile/flagsmith-ios-client-sdk into fix/false-positive-realtime-flag-updates
…mpleting within the 10 second time limit and also removed a warning.
matthewelwell
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #76
Description
Added a local cache of the last fetched data and tested any new data for equality before firing it out to consumers of our flag stream.
Also had a hunch we might not be adding keep-alive headers, but that seems to already be the case.
Regression Test Recommendations
I've tested this manually using the Example app, Flagsmith console and console logging in XCode and it seems to work well.
I've also added a unit test to cover this, and all current tests pass.
Type of Change