feat: Expose ConnectionPool customization on FlagsmithConfig.Builder#208
Merged
feat: Expose ConnectionPool customization on FlagsmithConfig.Builder#208
Conversation
Add connectionPool(ConnectionPool) to FlagsmithConfig.Builder so users can tune how long OkHttp keeps idle connections alive and how many it retains. This addresses stale connection reuse when running behind intermediaries (AWS ALB, nginx) that close idle sockets sooner than OkHttp's default of 5 minutes. Passing null, or not calling the method, preserves OkHttp's defaults. Existing users see no behavior change. Closes #207
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
connectionPool(ConnectionPool)toFlagsmithConfig.Builderso users can tune OkHttp's idle connection behavior (keepAlive duration and max idle connections). This is the API requested in #207 for users running behind intermediaries (AWS ALB, nginx) that close idle sockets sooner than OkHttp's default of 5 minutes.Default behavior is unchanged: when
connectionPool()is not called (or is called withnull), OkHttp's default pool is used, so existing users see no difference.Usage
Tests
Two new tests in
FlagsmithConfigTest:configTest_customConnectionPool_respectsKeepAliveAndMaxIdlereflects intoConnectionPool.delegateand asserts the user'smaxIdleConnectionsandkeepAliveDurationNsreach the live pool. Mutation tested: removing the constructor wiring fails this test.configTest_nullConnectionPool_isSafeAndUsesDefaultpassesnullexplicitly and asserts no NPE; a default OkHttp pool is still wired. Mutation tested: removing the null guard fails this test.Both tests pass on OkHttp 5.x and OkHttp 4.x (via the
test-okhttp4profile).