Ignore undefined traits when identifying / calling setTrait(s) or identify#168
Merged
Ignore undefined traits when identifying / calling setTrait(s) or identify#168
Conversation
kyle-ssg
changed the title
matthewelwell
approved these changes
Mar 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this, each of the following would fail to set traits / identify https://github.com/Flagsmith/flagsmith-js-client/pull/168/files#diff-0b9b511548a3e7571b5371b6ad98facf6955df9dfa855af7107b182e04bc524bR216
Now traits that have undefined values will be ignored and won't be sent to the API.
If the user has enableLogs set to true it will result in the following log:
