fix: environment evaluation skip segments #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khvn26
reviewed
Oct 30, 2025
khvn26
reviewed
Oct 30, 2025
khvn26
approved these changes
Oct 30, 2025
khvn26
reviewed
Oct 30, 2025
khvn26
requested changes
Oct 30, 2025
Member
khvn26
left a comment
khvn26
left a comment
There was a problem hiding this comment.
A couple of minor comments, otherwise good to go IMO.
khvn26
approved these changes
Nov 12, 2025
Zaimwa9
merged commit 2e60f40
into
chore/update-to-latest-evaluation-schemas
3 checks passed
Zaimwa9
added a commit
that referenced
this pull request
Nov 12, 2025
* feat: removed-feature-key-and-segment-key-from-schema * feat: re-organized-models * chore: camel-cased-flagsmith-id * chore: throw-error-if-metadata-missing * feat: boolean-trait-returns-false-in-operator * feat: implemented-implicit-identity-key (#211) * fix: environment evaluation skip segments (#213) * feat: implemented-implicit-identity-key * fix: skip-segment-if-environment-flag-and-moved-flagsmith-id-to-id * fix: rename-custom-to-sdk-metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #212
Changes:
getEnvironmentFlagsFromDocument