Skip to content

fix: Implicit identity key not supported for % Split operator #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 28, 2025
Merged

fix: Implicit identity key not supported for % Split operator #115

merged 6 commits into from
Oct 28, 2025

Conversation

@khvn26
Copy link
Member

@khvn26 khvn26 commented Oct 27, 2025 •
edited
Loading

Contributes to #114, #113.

In this PR, we:

  • Bring the evaluation context schema up to speed with engine-test-data v3.0.0.
  • Fix a bug when implicit identity keys weren't used for % Split segment conditions.
  • Fix a bug when boolean context values were evaluated against the In segment conditions.

@khvn26 khvn26 requested a review from a team as a code owner October 27, 2025 15:36
@khvn26 khvn26 requested review from gagantrivedi and removed request for a team October 27, 2025 15:36
@khvn26 khvn26 requested a review from a team October 27, 2025 16:26
Zaimwa9
Zaimwa9 reviewed Oct 27, 2025
View reviewed changes
Zaimwa9
Zaimwa9 previously approved these changes Oct 27, 2025
View reviewed changes
Copy link
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking to me besides a cross-sdk question

@khvn26 khvn26 mentioned this pull request Oct 27, 2025
Open
Copilot AI mentioned this pull request Oct 27, 2025
Open
12 tasks
@khvn26 khvn26 requested a review from Zaimwa9 October 27, 2025 17:25
Zaimwa9
Zaimwa9 previously approved these changes Oct 28, 2025
View reviewed changes
@khvn26 khvn26 requested a review from Zaimwa9 October 28, 2025 14:22
@khvn26 khvn26 merged commit a9d1e23 into main Oct 28, 2025
3 checks passed
@khvn26 khvn26 deleted the fix/implicit-identity-key-for-percentage-split branch October 28, 2025 14:32
@flagsmithdev flagsmithdev mentioned this pull request Oct 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zaimwa9 Zaimwa9 Zaimwa9 approved these changes

@gagantrivedi gagantrivedi Awaiting requested review from gagantrivedi gagantrivedi is a code owner automatically assigned from Flagsmith/flagsmith-back-end

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khvn26 @Zaimwa9