Skip to content

Conversation

@matthewelwell
Copy link
Contributor

@matthewelwell matthewelwell commented Apr 1, 2025

Replaces third party publishing flow with the official pypa action (copied from here).

I have configured the auth on the pypi side as per the following screenshot.

image

@github-actions github-actions bot added the ci-cd label Apr 1, 2025
@matthewelwell matthewelwell requested review from a team and gagantrivedi and removed request for a team April 1, 2025 10:11
@khvn26
Copy link
Member

khvn26 commented Apr 1, 2025

Consider switching to the official pypa action + oidc? Refer to flagsmith-common as an example

@github-actions github-actions bot added ci-cd and removed ci-cd labels Apr 1, 2025
@matthewelwell
Copy link
Contributor Author

Replace publish workflow with official pypa action

Done Replace publish workflow with official pypa action @khvn26

@matthewelwell matthewelwell changed the title ci: fix publish workflow ci: replace publish workflow Apr 1, 2025
@khvn26
Copy link
Member

khvn26 commented Apr 1, 2025

Make sure you've added the publisher repo/workflow name in PyPI's package settings before merging this.

@github-actions github-actions bot added ci-cd and removed ci-cd labels Apr 1, 2025
@matthewelwell
Copy link
Contributor Author

matthewelwell commented Apr 1, 2025

Make sure you've added the publisher repo/workflow name in PyPI's package settings before merging this.

Ya, already done - see PR description.


- uses: actions/setup-python@v4
with:
fetch-depth: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe keep it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@github-actions github-actions bot added ci-cd and removed ci-cd labels Apr 1, 2025
@matthewelwell matthewelwell merged commit 7a335eb into main Apr 1, 2025
7 checks passed
@matthewelwell matthewelwell deleted the ci/fix-publish-workflow branch April 1, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants