Skip to content

fix: TypeError: 'NoneType' object is not subscriptable (Python 3.11) #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2025
Merged

fix: TypeError: 'NoneType' object is not subscriptable (Python 3.11) #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flagsmith/api/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class MultivariateFeatureStateValueModel(typing.TypedDict):

class FeatureStateModel(typing.TypedDict):
enabled: bool
feature_segment: NotRequired[FeatureSegmentModel]
feature_segment: NotRequired[typing.Optional[FeatureSegmentModel]]
feature_state_value: object
feature: FeatureModel
featurestate_uuid: str
Expand Down
4 changes: 2 additions & 2 deletions flagsmith/mappers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ def _map_environment_document_feature_states_to_feature_contexts(
for multivariate_feature_state_value in multivariate_feature_state_values
]

if "feature_segment" in feature_state:
feature_context["priority"] = feature_state["feature_segment"]["priority"]
if feature_segment := feature_state.get("feature_segment"):
feature_context["priority"] = feature_segment["priority"]

yield feature_context
3 changes: 2 additions & 1 deletion tests/data/environment.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@
"id": 1
},
"segment_id": null,
"enabled": true
"enabled": true,
"feature_segment": null
}
],
"updated_at": "2023-07-14 16:12:00.000000",
Expand Down