Skip to content

fix(SCIM): drop service-provider settings django-scim2 ignores#7519

Merged
emyller merged 1 commit into
mainfrom
fix/scim-drop-dead-service-provider-keys
May 14, 2026
Merged

fix(SCIM): drop service-provider settings django-scim2 ignores#7519
emyller merged 1 commit into
mainfrom
fix/scim-drop-dead-service-provider-keys

Conversation

@emyller
Copy link
Copy Markdown
Contributor

@emyller emyller commented May 14, 2026

The api's SCIM_SERVICE_PROVIDER block declares six settings (BULK, CHANGE_PASSWORD, ETAG, FILTER, SORT, PATCH) that django-scim2 does not read. Operators tuning them today believe they are shaping the ServiceProviderConfig response; they are not. The actual response shape comes from hardcoded values in django-scim2's own SCIMServiceProviderConfig.to_dict(). The matching test asserts a contract that the library does not honour.

Changes

  • Operators no longer carry settings that have no runtime effect

Review effort: 1/5

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored May 14, 2026 6:35pm
flagsmith-frontend-preview Ignored Ignored May 14, 2026 6:35pm
flagsmith-frontend-staging Ignored Ignored May 14, 2026 6:35pm

Request Review

@emyller emyller requested a review from a team as a code owner May 14, 2026 18:35
@emyller emyller requested review from khvn26 and removed request for a team May 14, 2026 18:35
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@github-actions github-actions Bot added api Issue related to the REST API fix labels May 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-frontend:pr-7519 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-e2e:pr-7519 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith:pr-7519 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-7519 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7519 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api-test:pr-7519 Finished ✅ Skipped

@emyller emyller merged commit 6168392 into main May 14, 2026
32 checks passed
@emyller emyller deleted the fix/scim-drop-dead-service-provider-keys branch May 14, 2026 18:39
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.47%. Comparing base (0047a5f) to head (fbe1750).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7519      +/-   ##
==========================================
- Coverage   98.47%   98.47%   -0.01%     
==========================================
  Files        1400     1400              
  Lines       52986    52980       -6     
==========================================
- Hits        52176    52170       -6     
  Misses        810      810              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  38.9 seconds
commit  fbe1750
info  🔄 Run: #16763 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  42.8 seconds
commit  fbe1750
info  🔄 Run: #16763 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  38.5 seconds
commit  fbe1750
info  🔄 Run: #16763 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  37 seconds
commit  fbe1750
info  🔄 Run: #16763 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

Visual Regression

16 screenshots compared. See report for details.
View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants