fix(SCIM): drop service-provider settings django-scim2 ignores#7519
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Docker builds report
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7519 +/- ##
==========================================
- Coverage 98.47% 98.47% -0.01%
==========================================
Files 1400 1400
Lines 52986 52980 -6
==========================================
- Hits 52176 52170 -6
Misses 810 810 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
|
Visual Regression16 screenshots compared. See report for details. |
The api's
SCIM_SERVICE_PROVIDERblock declares six settings (BULK,CHANGE_PASSWORD,ETAG,FILTER,SORT,PATCH) that django-scim2 does not read. Operators tuning them today believe they are shaping the ServiceProviderConfig response; they are not. The actual response shape comes from hardcoded values in django-scim2's ownSCIMServiceProviderConfig.to_dict(). The matching test asserts a contract that the library does not honour.Changes
Review effort: 1/5