feat: track custom event feature creation#7603
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request updates the @flagsmith/flagsmith dependency, configures autoTrackEvaluations to false in the evaluation analytics configuration, and introduces tracking for feature creation events (first_feature_created and feature_created). The review comments point out a critical bug where state mutations and tracking for the first feature creation are executed synchronously before the API call succeeds. If the API call fails, subsequent retries will incorrectly track standard feature events instead of the first feature event. It is recommended to move these state mutations and tracking calls into the successful API response callback.
Docker builds report
|
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
|
Visual Regression19 screenshots compared. See report for details. |
…ustom-event-for-experimentation
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
create_featureeventsHow did you test this code?