Skip to content

feat: track custom event feature creation#7603

Merged
Zaimwa9 merged 4 commits into
mainfrom
feat/add-custom-event-for-experimentation
May 28, 2026
Merged

feat: track custom event feature creation#7603
Zaimwa9 merged 4 commits into
mainfrom
feat/add-custom-event-for-experimentation

Conversation

@Zaimwa9
Copy link
Copy Markdown
Contributor

@Zaimwa9 Zaimwa9 commented May 26, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

  • Bumped flagsmith internal version
  • track create_featureevents

How did you test this code?

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner May 26, 2026 15:42
@Zaimwa9 Zaimwa9 requested review from talissoncosta and removed request for a team May 26, 2026 15:42
@vercel
Copy link
Copy Markdown

vercel Bot commented May 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment May 28, 2026 7:34am
flagsmith-frontend-staging Ready Ready Preview, Comment May 28, 2026 7:34am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview May 28, 2026 7:34am

Request Review

@Zaimwa9 Zaimwa9 marked this pull request as draft May 26, 2026 15:42
@github-actions github-actions Bot added the front-end Issue related to the React Front End Dashboard label May 26, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @flagsmith/flagsmith dependency, configures autoTrackEvaluations to false in the evaluation analytics configuration, and introduces tracking for feature creation events (first_feature_created and feature_created). The review comments point out a critical bug where state mutations and tracking for the first feature creation are executed synchronously before the API call succeeds. If the API call fails, subsequent retries will incorrectly track standard feature events instead of the first feature event. It is recommended to move these state mutations and tracking calls into the successful API response callback.

Comment thread frontend/common/stores/feature-list-store.ts Outdated
Comment thread frontend/common/stores/feature-list-store.ts
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 26, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7603 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7603 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7603 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7603 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-e2e:pr-7603 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-7603 Finished ✅ Results

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 26, 2026

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  42.3 seconds
commit  c0ba9db
info  🔄 Run: #17009 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  39.2 seconds
commit  c0ba9db
info  🔄 Run: #17009 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  32.6 seconds
commit  c0ba9db
info  🔄 Run: #17009 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  39.8 seconds
commit  c0ba9db
info  🔄 Run: #17009 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  39.3 seconds
commit  c6a4e5d
info  🔄 Run: #17049 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  42.2 seconds
commit  c6a4e5d
info  🔄 Run: #17049 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  32.8 seconds
commit  c6a4e5d
info  🔄 Run: #17049 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  53.7 seconds
commit  c6a4e5d
info  🔄 Run: #17049 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 26, 2026

Visual Regression

19 screenshots compared. See report for details.
View full report

@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels May 28, 2026
@Zaimwa9 Zaimwa9 marked this pull request as ready for review May 28, 2026 07:42
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels May 28, 2026
@Zaimwa9 Zaimwa9 requested review from gagantrivedi and removed request for talissoncosta May 28, 2026 07:43
@Zaimwa9 Zaimwa9 merged commit cac20ff into main May 28, 2026
42 of 43 checks passed
@Zaimwa9 Zaimwa9 deleted the feat/add-custom-event-for-experimentation branch May 28, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants