fix: return 400 when environment is null in featurestate update#7957
Merged
Zaimwa9 merged 2 commits intoJul 13, 2026
Conversation
Add null check in validate_environment to prevent AttributeError crash
when a null environment is passed in the payload to
/api/v1/features/featurestates/{pk}/.
Fixes Flagsmith#6597
|
@mangodxd is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7957 +/- ##
==========================================
- Coverage 98.63% 98.49% -0.15%
==========================================
Files 1497 1497
Lines 59189 59192 +3
==========================================
- Hits 58383 58299 -84
- Misses 806 893 +87 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Zaimwa9
approved these changes
Jul 13, 2026
Zaimwa9
left a comment
Zaimwa9
left a comment
Contributor
There was a problem hiding this comment.
Looking good to me. Thanks for your first contribution!
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a 500 crash in
/api/v1/features/featurestates/{pk}/when theenvironmentfield isnullin the request payload.Root cause:
validate_environmentinFeatureStateSerializerBasiccallsenvironment.idwithout checking ifenvironmentisNonefirst, causing anAttributeError: 'NoneType' object has no attribute 'id'.Fix: Added a null check at the beginning of
validate_environmentthat returns a 400 validation error with the message"Environment may not be null."when the environment field is null.Changes
api/features/serializers.py: Added null check invalidate_environmentmethodapi/tests/unit/features/test_unit_features_views.py: Added regression testtest_update_feature_state__null_environment__returns_400Related