feat: add unique analytics IDs to experiment, metric, and warehouse buttons#7997
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Docker builds report
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
📝 WalkthroughWalkthroughAdds stable HTML Estimated code review effort: 2 (Simple) | ~10 minutes Comment |
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
|
Visual Regression19 screenshots compared. See report for details. |
docs/if required so people know about the feature.Changes
Adds unique
idattributes to buttons across the experiment wizard, metrics page, and warehouse setup so Amplitude autocapture can distinguish elements that share the same text label (e.g. multiple "Continue" and "Create Metric" buttons).Experiment wizard — step-aware IDs on Continue, Back, Create Experiment, Split evenly, review Edit buttons, and Create Metric buttons in the measurement step.
Metrics page — IDs on Create Metric buttons (empty state vs listing), form submit/cancel, and per-row edit/delete in the metrics table.
Warehouse setup — IDs on Enable, config form save/cancel, connection card edit/delete/test/send-first-event.
Naming convention:
{flow}-{context}-{action}(e.g.experiment-wizard-setup-continue,metrics-page-create,warehouse-config-save).How did you test this code?
Typecheck (
npm run typecheck) and lint (eslint --fix) pass with no new errors. Visual inspection of ID uniqueness across all three flows.