fix(experimentation): poll warehouse status for created connections#8001
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughWarehouse polling now occurs every 60 seconds when the connection status is Estimated code review effort: 1 (Trivial) | ~3 minutes Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8001 +/- ##
=======================================
Coverage 98.63% 98.63%
=======================================
Files 1496 1496
Lines 59072 59154 +82
=======================================
+ Hits 58266 58348 +82
Misses 806 806 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
6602e39 to
a4c36df
Compare
Docker builds report
|
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Failed testsfirefox › tests/project-permission-test.pw.ts › Project Permission Tests › Project-level permissions control access to features, environments, audit logs, and segments @enterprise Details
|
Visual Regression19 screenshots compared. See report for details. |
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
A warehouse connection's status is only evaluated by the test-connection endpoint, and the Warehouse tab only
polled it while a connection was
pending_connection. A connection increatedstatus therefore never advancedto
connected, even with application events already flowing, until someone clicked "Send your first event".The Warehouse tab now polls the test-connection endpoint for
createdconnections too, so a warehouse that isalready receiving application events connects by simply opening the tab. No backend changes: GET endpoints stay
read-only, and the existing POST endpoint handles the status transitions.
How did you test this code?
warehousePolling.test.ts).npx eslintclean on the changed files.