Skip to content

fix(experimentation): poll warehouse status for created connections#8001

Merged
Zaimwa9 merged 2 commits into
mainfrom
fix/warehouse-connect-on-read
Jul 14, 2026
Merged

fix(experimentation): poll warehouse status for created connections#8001
Zaimwa9 merged 2 commits into
mainfrom
fix/warehouse-connect-on-read

Conversation

@Zaimwa9

@Zaimwa9 Zaimwa9 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

A warehouse connection's status is only evaluated by the test-connection endpoint, and the Warehouse tab only
polled it while a connection was pending_connection. A connection in created status therefore never advanced
to connected, even with application events already flowing, until someone clicked "Send your first event".

The Warehouse tab now polls the test-connection endpoint for created connections too, so a warehouse that is
already receiving application events connects by simply opening the tab. No backend changes: GET endpoints stay
read-only, and the existing POST endpoint handles the status transitions.

How did you test this code?

  • Unit tests for the polling interval (warehousePolling.test.ts).
  • npx eslint clean on the changed files.

@vercel

vercel Bot commented Jul 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Jul 14, 2026 9:01am
flagsmith-frontend-staging Ready Ready Preview, Comment Jul 14, 2026 9:01am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Jul 14, 2026 9:01am

Request Review

@github-actions github-actions Bot added api Issue related to the REST API docs Documentation updates labels Jul 14, 2026
@github-actions github-actions Bot added fix and removed docs Documentation updates labels Jul 14, 2026
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2872fedf-d512-4c78-b2f0-f5122bde6113

📥 Commits

Reviewing files that changed from the base of the PR and between 26a1e29 and b2d0f8b.

📒 Files selected for processing (2)
  • frontend/web/components/pages/environment-settings/tabs/warehouse-tab/__tests__/warehousePolling.test.ts
  • frontend/web/components/pages/environment-settings/tabs/warehouse-tab/warehousePolling.ts

📝 Walkthrough

Walkthrough

Warehouse polling now occurs every 60 seconds when the connection status is created or pending_connection. Other statuses continue to disable polling. The corresponding test was updated to expect a 60000 ms interval for the created status.

Estimated code review effort: 1 (Trivial) | ~3 minutes


Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.63%. Comparing base (1c73453) to head (6602e39).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8001   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files        1496     1496           
  Lines       59072    59154   +82     
=======================================
+ Hits        58266    58348   +82     
  Misses        806      806           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Zaimwa9 Zaimwa9 force-pushed the fix/warehouse-connect-on-read branch from 6602e39 to a4c36df Compare July 14, 2026 07:44
@Zaimwa9 Zaimwa9 changed the title fix(experimentation): connect warehouse on read when events exist fix(experimentation): poll warehouse status for created connections Jul 14, 2026
@github-actions github-actions Bot added the front-end Issue related to the React Front End Dashboard label Jul 14, 2026
@github-actions github-actions Bot added fix and removed fix labels Jul 14, 2026
@github-actions github-actions Bot added fix and removed fix labels Jul 14, 2026
@Zaimwa9 Zaimwa9 requested a review from gagantrivedi July 14, 2026 09:02
@Zaimwa9 Zaimwa9 marked this pull request as ready for review July 14, 2026 09:02
@Zaimwa9 Zaimwa9 requested a review from a team as a code owner July 14, 2026 09:02
@Zaimwa9 Zaimwa9 requested review from kyle-ssg and removed request for a team July 14, 2026 09:02
@github-actions github-actions Bot added fix and removed fix labels Jul 14, 2026
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-8001 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-8001 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-8001 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8001 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-e2e:pr-8001 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-8001 Finished ✅ Results

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  40.8 seconds
commit  b2d0f8b
info  🔄 Run: #18232 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  40.4 seconds
commit  b2d0f8b
info  🔄 Run: #18232 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  6 passed

Details

stats  6 tests across 5 suites
duration  36.4 seconds
commit  b2d0f8b
info  🔄 Run: #18232 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

failed  1 failed
passed  1 passed

Details

stats  2 tests across 2 suites
duration  1 minute, 14 seconds
commit  b2d0f8b
info  📦 Artifacts: View test results and HTML report
🔄 Run: #18232 (attempt 1)

Failed tests

firefox › tests/project-permission-test.pw.ts › Project Permission Tests › Project-level permissions control access to features, environments, audit logs, and segments @enterprise

### Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  5 passed

Details

stats  5 tests across 4 suites
duration  35.2 seconds
commit  b2d0f8b
info  🔄 Run: #18232 (attempt 2)

@github-actions

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

@Zaimwa9 Zaimwa9 merged commit 038238b into main Jul 14, 2026
57 of 58 checks passed
@Zaimwa9 Zaimwa9 deleted the fix/warehouse-connect-on-read branch July 14, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants