fix: ClickHouse form follow-ups from #8028 review by Zaimwa9 · Pull Request #8092 · Flagsmith/flagsmith

Zaimwa9 · 2026-07-24T08:44:20Z

Thanks for submitting a PR! Please check the boxes below:

I have read the Contributing Guide.
I have added information to docs/ if required so people know about the feature.
I have filled in the "Changes" section below.
I have filled in the "How did you test this code" section below.

Changes

Follow-ups to non-blocking review comments on #8028:

Trim whitespace from pasted values before validating and building the payload (password left intact).
Inline error under the port field when it's not between 1 and 65535.
A failed test no longer fires a danger toast on top of the warning banner.
autocomplete="new-password" on the password input.

How did you test this code?

Unit tests (npm run test:unit -- --testPathPatterns=warehouse-tab), lint, typecheck. Manually: pasted values with trailing whitespace, invalid port, failed test.

vercel · 2026-07-24T08:44:27Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
flagsmith-frontend-preview	Ready	Preview, Comment	Jul 24, 2026 12:43pm
flagsmith-frontend-staging	Ready	Preview, Comment	Jul 24, 2026 12:43pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Ignored	Preview	Jul 24, 2026 12:43pm

coderabbitai · 2026-07-24T08:44:28Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 89bfc1c8-e92e-485d-b4f5-b715ff8d5053

📥 Commits

Reviewing files that changed from the base of the PR and between 43faf52 and ab5e2ce.

📒 Files selected for processing (1)

frontend/web/components/pages/environment-settings/tabs/warehouse-tab/ClickHouseConfigForm.tsx

📝 Walkthrough

Walkthrough

ClickHouse configuration handling now trims relevant fields, validates ports after trimming, normalises payload values, and ignores equivalent formatting when checking dirtiness. The form displays accessible invalid-port feedback, records connection-test failures as errored without the previous failure toast, and specifies new-password autocomplete for the password field. Tests cover whitespace handling for ports, hosts, payload fields, and passwords.

Estimated code review effort: 2 (Simple) | ~10 minutes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Zaimwa9 · 2026-07-24T08:45:25Z

@themis-blindfold review

github-actions · 2026-07-24T08:46:20Z

Docker builds report

Image	Build Status	Security report
`ghcr.io/flagsmith/flagsmith-api-test:pr-8092`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-e2e:pr-8092`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-api:pr-8092`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith:pr-8092`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-private-cloud:pr-8092`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-frontend:pr-8092`	Finished ✅	Results ✅

themis-blindfold · 2026-07-24T08:51:04Z

⚖️ Themis judgement: ✅ Ship it

Tidy follow-up to #8028 addressing four review comments: whitespace trimming on pasted values (password intentionally left intact), inline port-range validation, removal of redundant danger toasts on test failure, and autocomplete="new-password" on the password input. The trimming is applied consistently in validation (isClickHouseFormValid, canTestClickHouseConnection), dirty-checking (isClickHouseConfigDirty), and payload construction (buildClickHousePayload). Tests cover the new behaviour well.


🎯 Correctness	5/5
🧪 Test coverage	4/5
📐 Code quality	5/5
🚀 Product impact	2/5

CI: unit tests, lint, and typecheck passed. E2E runs were still in progress; build and static-analysis checks all succeeded.

📝 Walkthrough

clickhouseConfig.ts — isValidPort trims before validating; isClickHouseFormValid, canTestClickHouseConnection, isClickHouseConfigDirty, and buildClickHousePayload all trim string fields (except password) before comparing or emitting.
ClickHouseConfigForm.tsx — inline port-range error below the port field; danger toasts removed from the test-connection failure paths (the warning banner already surfaces the detail); autocomplete='new-password' added to the password <Input>.
clickhouseConfig.test.ts — new cases for whitespace-trimmed port validation, whitespace-only host rejection, and a full round-trip trim test in buildClickHousePayload.

🧪 How to verify

Paste a host value with leading/trailing whitespace; confirm the form accepts it and the payload trims it (inspect network request on save).
Type 0, 65536, or abc in the port field; confirm the inline error appears and the form cannot be submitted.
Trigger a connection-test failure; confirm no danger toast appears — only the inline warning banner.
Inspect the password <input> element in the browser; confirm autocomplete="new-password" is present.
Run npm run test:unit -- --testPathPatterns=warehouse-tab and confirm all tests pass.

Automate: the existing unit tests cover trimming, port validation, and payload shape; no additional automated checks needed beyond E2E coverage of the warehouse tab.

Product take: Minor UX polish — prevents accidental whitespace in connection details from causing confusing failures, and stops duplicate error feedback on a failed test. Nice quality-of-life improvement but not a capability change.

🧭 Assumptions & unverified claims

No unverified assumptions or claims.

A clean diff that trims the fat (and the whitespace) — exactly what follow-ups should look like. · reviewed at 56d8b6a

github-actions · 2026-07-24T08:51:22Z

✅ private-cloud · depot-ubuntu-latest-16 — run #18705 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

3 passed

Details

3 tests across 3 suites
35.7 seconds
ab5e2ce
🔄 Run: #18705 (attempt 1)

🗂️ Previous results

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #18705 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
1 minute, 4 seconds
ab5e2ce
🔄 Run: #18705 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #18705 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
44.4 seconds
ab5e2ce
🔄 Run: #18705 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #18705 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
40.3 seconds
ab5e2ce
🔄 Run: #18705 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #18704 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

2 passed

Details

2 tests across 2 suites
1 minute, 1 second
43faf52
🔄 Run: #18704 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #18704 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
34.3 seconds
43faf52
🔄 Run: #18704 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #18704 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
43.3 seconds
43faf52
🔄 Run: #18704 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #18704 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
40.5 seconds
43faf52
🔄 Run: #18704 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #18693 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

2 passed

Details

2 tests across 2 suites
57.3 seconds
33234e1
🔄 Run: #18693 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #18693 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

2 passed

Details

2 tests across 2 suites
1 minute, 3 seconds
33234e1
🔄 Run: #18693 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #18693 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

2 passed

Details

2 tests across 2 suites
46 seconds
33234e1
🔄 Run: #18693 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #18693 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
33.2 seconds
33234e1
🔄 Run: #18693 (attempt 1)

coderabbitai

Actionable comments posted: 2

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 06fcfd4b-3c7e-450e-b31b-827090bacf5d

📥 Commits

Reviewing files that changed from the base of the PR and between 30bf03a and 56d8b6a.

📒 Files selected for processing (3)

frontend/web/components/pages/environment-settings/tabs/warehouse-tab/ClickHouseConfigForm.tsx
frontend/web/components/pages/environment-settings/tabs/warehouse-tab/__tests__/clickhouseConfig.test.ts
frontend/web/components/pages/environment-settings/tabs/warehouse-tab/clickhouseConfig.ts

github-actions · 2026-07-24T08:53:43Z

Visual Regression

19 screenshots compared. See report for details.
View full report

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

frontend/web/components/pages/environment-settings/tabs/warehouse-tab/__tests__/clickhouseConfig.test.ts (1)

27-30: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Cover invalid boundaries after trimming.

This test proves that ' 9440 ' is accepted, but add cases such as ' 0 ' and ' 65536 ' to ensure trimming does not bypass the range checks.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7fabd2ff-9263-47ab-943b-9fb7583ca9c4

📥 Commits

Reviewing files that changed from the base of the PR and between 56d8b6a and 33234e1.

📒 Files selected for processing (3)

frontend/web/components/pages/environment-settings/tabs/warehouse-tab/ClickHouseConfigForm.tsx
frontend/web/components/pages/environment-settings/tabs/warehouse-tab/__tests__/clickhouseConfig.test.ts
frontend/web/components/pages/environment-settings/tabs/warehouse-tab/clickhouseConfig.ts

…le failure message, no password autofill

…factor

talissoncosta

Looks great!

github-actions Bot added the front-end Issue related to the React Front End Dashboard label Jul 24, 2026

vercel Bot deployed to Preview – flagsmith-frontend-preview July 24, 2026 08:44 View deployment

vercel Bot deployed to Preview – flagsmith-frontend-staging July 24, 2026 08:44 View deployment

Zaimwa9 marked this pull request as ready for review July 24, 2026 08:45

Zaimwa9 requested a review from a team as a code owner July 24, 2026 08:45

Zaimwa9 requested review from kyle-ssg and removed request for a team July 24, 2026 08:45

github-actions Bot added the fix label Jul 24, 2026

github-actions Bot added fix and removed fix labels Jul 24, 2026

coderabbitai Bot reviewed Jul 24, 2026

View reviewed changes

Comment thread frontend/web/components/pages/environment-settings/tabs/warehouse-tab/clickhouseConfig.ts

Comment thread frontend/web/components/pages/environment-settings/tabs/warehouse-tab/ClickHouseConfigForm.tsx Outdated

vercel Bot deployed to Preview – flagsmith-frontend-staging July 24, 2026 09:14 View deployment

vercel Bot deployed to Preview – flagsmith-frontend-preview July 24, 2026 09:14 View deployment

github-actions Bot added fix and removed fix labels Jul 24, 2026

Zaimwa9 requested a review from talissoncosta July 24, 2026 09:15

coderabbitai Bot reviewed Jul 24, 2026

View reviewed changes

Zaimwa9 added 3 commits July 24, 2026 14:17

fix: clickhouse form follow-ups: trim inputs, inline port error, sing…

438b996

…le failure message, no password autofill

fix: aria wiring on port error and numeric port dirty comparison

96d28bc

fix: rename autocomplete prop to standard autoComplete after input re…

43faf52

…factor

Zaimwa9 force-pushed the fix/clickhouse-form-follow-ups branch from 33234e1 to 43faf52 Compare July 24, 2026 12:18

vercel Bot deployed to Preview – flagsmith-frontend-preview July 24, 2026 12:19 View deployment

vercel Bot deployed to Preview – flagsmith-frontend-staging July 24, 2026 12:19 View deployment

github-actions Bot added fix and removed fix labels Jul 24, 2026

talissoncosta previously approved these changes Jul 24, 2026

View reviewed changes

talissoncosta reviewed Jul 24, 2026

View reviewed changes

Comment thread frontend/web/components/pages/environment-settings/tabs/warehouse-tab/ClickHouseConfigForm.tsx Outdated

refactor: use FieldError primitive for the inline port error

ab5e2ce

Zaimwa9 dismissed talissoncosta’s stale review via ab5e2ce July 24, 2026 12:42

vercel Bot deployed to Preview – flagsmith-frontend-preview July 24, 2026 12:43 View deployment

vercel Bot deployed to Preview – flagsmith-frontend-staging July 24, 2026 12:43 View deployment

github-actions Bot added fix and removed fix labels Jul 24, 2026

talissoncosta approved these changes Jul 24, 2026

View reviewed changes

Zaimwa9 merged commit 80e50a2 into main Jul 24, 2026
29 checks passed

Zaimwa9 deleted the fix/clickhouse-form-follow-ups branch July 24, 2026 12:59

flagsmith-engineering Bot mentioned this pull request Jul 24, 2026

chore(main): release 2.256.0 #8058

Open

Uh oh!

Conversation

Zaimwa9 commented Jul 24, 2026

Changes

How did you test this code?

Uh oh!

vercel Bot commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

Zaimwa9 commented Jul 24, 2026

Uh oh!

github-actions Bot commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Docker builds report

Uh oh!

themis-blindfold Bot commented Jul 24, 2026

⚖️ Themis judgement: ✅ Ship it

Uh oh!

github-actions Bot commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Visual Regression

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

talissoncosta left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel Bot commented Jul 24, 2026 •

edited

Loading

coderabbitai Bot commented Jul 24, 2026 •

edited

Loading

github-actions Bot commented Jul 24, 2026 •

edited

Loading

github-actions Bot commented Jul 24, 2026 •

edited

Loading

github-actions Bot commented Jul 24, 2026 •

edited

Loading