fix(MCP): deploy the released image instead of redeploying the old one#8093
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds a reusable composite GitHub Action for updating an ECS service from its live task definition, replacing a selected container image, and waiting for deployment stability. The MCP Docker workflow now exposes staging and production image outputs, prioritises the staging SHA tag, and uses the shared action for both deployment paths instead of inline AWS ECS commands. Estimated code review effort: 3 (Moderate) | ~20 minutes Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Docker builds report
|
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 90780f7a-28b0-4384-86df-35e636a3a4d0
📒 Files selected for processing (2)
.github/actions/mcp-deploy-ecs/action.yml.github/workflows/mcp-docker-build-publish-deploy.yml
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #18697 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
🗂️ Previous results✅ private-cloud · depot-ubuntu-latest-16 — run #18697 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
✅ oss · depot-ubuntu-latest-arm-16 — run #18697 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
✅ oss · depot-ubuntu-latest-16 — run #18697 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)Details
✅ private-cloud · depot-ubuntu-latest-16 — run #18696 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #18696 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
✅ oss · depot-ubuntu-latest-arm-16 — run #18696 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
✅ oss · depot-ubuntu-latest-16 — run #18696 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)Details
|
Visual Regression19 screenshots compared. See report for details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8093 +/- ##
=======================================
Coverage 98.69% 98.69%
=======================================
Files 1525 1525
Lines 60605 60605
=======================================
Hits 59817 59817
Misses 788 788 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The MCP task definition now points at a fixed image version (set by Pulumi) instead of a moving
latesttag. The old deploy step only forced a restart, so it kept running the same pinned version — new releases never went live. This makes the deploy step actually put the released image onto the service.Changes
Before merge
Review effort: 2/5