Skip to content

fix(MCP): deploy the released image instead of redeploying the old one#8093

Merged
germangarces merged 2 commits into
mainfrom
fix/mcp-version-controlled-deploy
Jul 24, 2026
Merged

fix(MCP): deploy the released image instead of redeploying the old one#8093
germangarces merged 2 commits into
mainfrom
fix/mcp-version-controlled-deploy

Conversation

@germangarces

@germangarces germangarces commented Jul 24, 2026

Copy link
Copy Markdown
Member

The MCP task definition now points at a fixed image version (set by Pulumi) instead of a moving latest tag. The old deploy step only forced a restart, so it kept running the same pinned version — new releases never went live. This makes the deploy step actually put the released image onto the service.

Changes

  • Deploy now updates the service to run the newly released image
  • Shared the deploy steps between staging and production so they can't drift apart

Before merge

  • Needs the matching AWS permissions, added in Pulumi PR Flagsmith/pulumi#288. That must land first, or the deploy step will fail.

Review effort: 2/5

@germangarces
germangarces requested a review from a team as a code owner July 24, 2026 10:12
@germangarces
germangarces requested review from talissoncosta and removed request for a team July 24, 2026 10:12
@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Jul 24, 2026 10:19am
flagsmith-frontend-preview Ignored Ignored Preview Jul 24, 2026 10:19am
flagsmith-frontend-staging Ignored Ignored Preview Jul 24, 2026 10:19am

Request Review

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ff26f408-a5ef-447a-90cd-99b542f173b3

📥 Commits

Reviewing files that changed from the base of the PR and between 215f69f and e974e14.

📒 Files selected for processing (2)
  • .github/actions/mcp-deploy-ecs/action.yml
  • .github/workflows/mcp-docker-build-publish-deploy.yml

📝 Walkthrough

Walkthrough

Adds a reusable composite GitHub Action for updating an ECS service from its live task definition, replacing a selected container image, and waiting for deployment stability. The MCP Docker workflow now exposes staging and production image outputs, prioritises the staging SHA tag, and uses the shared action for both deployment paths instead of inline AWS ECS commands.

Estimated code review effort: 3 (Moderate) | ~20 minutes


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the fix label Jul 24, 2026
@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-8093 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-8093 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-8093 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-8093 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-8093 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8093 Finished ✅ Results

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 90780f7a-28b0-4384-86df-35e636a3a4d0

📥 Commits

Reviewing files that changed from the base of the PR and between 44b2464 and 215f69f.

📒 Files selected for processing (2)
  • .github/actions/mcp-deploy-ecs/action.yml
  • .github/workflows/mcp-docker-build-publish-deploy.yml

Comment thread .github/actions/mcp-deploy-ecs/action.yml Outdated
Comment thread .github/workflows/mcp-docker-build-publish-deploy.yml Outdated
@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #18697 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  6.6 seconds
commit  e974e14
info  🔄 Run: #18697 (attempt 1)

🗂️ Previous results
✅ private-cloud · depot-ubuntu-latest-16 — run #18697 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  32.2 seconds
commit  e974e14
info  🔄 Run: #18697 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #18697 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  41.2 seconds
commit  e974e14
info  🔄 Run: #18697 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #18697 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  34.4 seconds
commit  e974e14
info  🔄 Run: #18697 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #18696 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  54.7 seconds
commit  215f69f
info  🔄 Run: #18696 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #18696 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  37.5 seconds
commit  215f69f
info  🔄 Run: #18696 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #18696 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  4.5 seconds
commit  215f69f
info  🔄 Run: #18696 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #18696 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  33.3 seconds
commit  215f69f
info  🔄 Run: #18696 (attempt 1)

@github-actions github-actions Bot added fix and removed fix labels Jul 24, 2026
@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.69%. Comparing base (1792fb2) to head (e974e14).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8093   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files        1525     1525           
  Lines       60605    60605           
=======================================
  Hits        59817    59817           
  Misses        788      788           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@khvn26 khvn26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@germangarces
germangarces merged commit 5e2c954 into main Jul 24, 2026
42 checks passed
@germangarces
germangarces deleted the fix/mcp-version-controlled-deploy branch July 24, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants