Skip to content

fix(onboarding): Onboarding marker PUT too restrictive#8097

Merged
khvn26 merged 1 commit into
mainfrom
fix/onboarding-too-restrictive
Jul 24, 2026
Merged

fix(onboarding): Onboarding marker PUT too restrictive#8097
khvn26 merged 1 commit into
mainfrom
fix/onboarding-too-restrictive

Conversation

@khvn26

@khvn26 khvn26 commented Jul 24, 2026

Copy link
Copy Markdown
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Chances that someone onboards via an old/custom SDK are low, but not zero.

How did you test this code?

N/A

@khvn26
khvn26 requested a review from a team as a code owner July 24, 2026 11:43
@khvn26
khvn26 requested review from emyller and removed request for a team July 24, 2026 11:43
@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Jul 24, 2026 11:43am
flagsmith-frontend-preview Ignored Ignored Jul 24, 2026 11:43am
flagsmith-frontend-staging Ignored Ignored Jul 24, 2026 11:43am

Request Review

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 538bac4d-2ac7-4752-b3d4-f89540282929

📥 Commits

Reviewing files that changed from the base of the PR and between 5e2c954 and 9e7dbd0.

📒 Files selected for processing (1)
  • api/environments/onboarding/serializers.py

📝 Walkthrough

Walkthrough

The onboarding status update serializer extends the first_evaluated_sdk_label ChoiceField to accept "unknown" in addition to values derived from KnownSDK.

Estimated code review effort: 1 (Trivial) | ~2 minutes


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the api Issue related to the REST API label Jul 24, 2026
@khvn26
khvn26 merged commit b9105aa into main Jul 24, 2026
21 of 22 checks passed
@github-actions github-actions Bot added the fix label Jul 24, 2026
@khvn26
khvn26 deleted the fix/onboarding-too-restrictive branch July 24, 2026 11:44
@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-8097 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-8097 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-8097 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-8097 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-8097 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8097 Finished ✅ Results

@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.69%. Comparing base (e97cef6) to head (9e7dbd0).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8097   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files        1525     1525           
  Lines       60605    60605           
=======================================
  Hits        59817    59817           
  Misses        788      788           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor
✅ private-cloud · depot-ubuntu-latest-16 — run #18700 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  48.8 seconds
commit  9e7dbd0
info  🔄 Run: #18700 (attempt 1)

🗂️ Previous results
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #18700 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  38.8 seconds
commit  9e7dbd0
info  🔄 Run: #18700 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #18700 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  42.6 seconds
commit  9e7dbd0
info  🔄 Run: #18700 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #18700 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  34.4 seconds
commit  9e7dbd0
info  🔄 Run: #18700 (attempt 1)

@github-actions

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants