Skip to content

feat: load HubSpot script on staging - #8293

Merged
Holmus merged 1 commit into
mainfrom
feat/hubspot-script-staging
Aug 14, 2026
Merged

feat: load HubSpot script on staging#8293
Holmus merged 1 commit into
mainfrom
feat/hubspot-script-staging

Conversation

@Holmus

@Holmus Holmus commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Adds the hubspot key to frontend/env/project_staging.js, pointing at the same portal as prod (143451822).

This is to enable the HubSpot chat button in staging for testing purposes.

🤖 Generated with Claude Code

@Holmus @claude
feat: load HubSpot script on staging
b184fa6 
The HubSpot tracking script is only injected when `Project.hubspot` is set
(frontend/web/project/libs.js). Of the env configs, only project_prod.js
defines it, so staging never loads the script and HubSpot has no visibility
of the environment at all.

This meant HubSpot chatflows targeting staging.flagsmith.com could never
match, since the widget's loader was never on the page. demo.flagsmith.com
and app.flagsmith.com both build with the prod config, which is why the chat
appears there but not on staging.

Points staging at the same portal (143451822) as prod so chatflow targeting
rules covering staging.flagsmith.com resolve.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@Holmus
Holmus requested a review from a team as a code owner August 14, 2026 13:28
@Holmus
Holmus requested review from talissoncosta and removed request for a team August 14, 2026 13:28
@vercel

vercel Bot commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview Aug 14, 2026 1:29pm
flagsmith-frontend-staging Ready Ready Preview Aug 14, 2026 1:29pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Aug 14, 2026 1:29pm

Request Review

@coderabbitai

coderabbitai Bot commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 000b2f8f-dce2-4b19-8dc6-ea5f624e2dae

📥 Commits

Reviewing files that changed from the base of the PR and between 608daaf and b184fa6.

📒 Files selected for processing (1)
  • frontend/env/project_staging.js
📝 Walkthrough

Walkthrough

The staging project settings now include a hubspot property. The property contains the EU HubSpot script URL.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to b184f

This change enables the existing HubSpot loader on staging while preserving the E2E suppression behavior; no actionable merge-blocking risk remains beyond normal checks and review.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the front-end Issue related to the React Front End Dashboard label Aug 14, 2026
@github-actions

github-actions Bot commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-8293 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-8293 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-8293 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8293 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-8293 Finished ✅ Results ✅

@github-actions github-actions Bot added the feature New feature or request label Aug 14, 2026
@github-actions

github-actions Bot commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
✅ private-cloud · depot-ubuntu-latest-16 — run #19354 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  32 seconds
commit  b184fa6
info  🔄 Run: #19354 (attempt 1)

🗂️ Previous results
✅ oss · depot-ubuntu-latest-arm-16 — run #19354 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  39.2 seconds
commit  b184fa6
info  🔄 Run: #19354 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #19354 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  40 seconds
commit  b184fa6
info  🔄 Run: #19354 (attempt 1)

@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

@Holmus
Holmus merged commit 75c1ad9 into main Aug 14, 2026
29 checks passed
@Holmus
Holmus deleted the feat/hubspot-script-staging branch August 14, 2026 13:54
@flagsmith-engineering flagsmith-engineering Bot mentioned this pull request Aug 14, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes
@Zaimwa9 Zaimwa9 Zaimwa9 approved these changes
@talissoncosta talissoncosta Awaiting requested review from talissoncosta talissoncosta is a code owner automatically assigned from Flagsmith/flagsmith-front-end

Assignees

No one assigned

Labels

feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Holmus @matthewelwell @Zaimwa9