Skip to content

fix: hide Try it out until the project has 3+ flags - #8419

Merged
Zaimwa9 merged 2 commits into
mainfrom
fix/gate-try-it-min-flags
Aug 31, 2026
Merged

fix: hide Try it out until the project has 3+ flags#8419
Zaimwa9 merged 2 commits into
mainfrom
fix/gate-try-it-min-flags

Conversation

@Zaimwa9

@Zaimwa9 Zaimwa9 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

"Run test" makes a real SDK call to flags/, marking the environment as integrated (environment.first_evaluated) from a single dashboard click. This skews onboarding conversion data for users who never wired an SDK.

  • Hide the "Try it out" section (features page and identity page) until the project has 3+ flags.
  • Bypass the gate under E2E so existing tryItExpect tests are unaffected.

How did you test this code?

Manually: with fewer than 3 flags the section is hidden; creating the 3rd flag reveals it without a reload (gate reads the live feature list count). Lint and typecheck clean on touched files.

@Zaimwa9
Zaimwa9 requested a review from a team as a code owner August 31, 2026 12:32
@Zaimwa9
Zaimwa9 requested review from talissoncosta and removed request for a team August 31, 2026 12:32
@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview Aug 31, 2026 12:43pm
flagsmith-frontend-staging Ready Ready Preview Aug 31, 2026 12:43pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Aug 31, 2026 12:43pm

Request Review

@github-actions github-actions Bot added the front-end Issue related to the React Front End Dashboard label Aug 31, 2026
@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-8419 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-8419 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-8419 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-8419 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8419 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-8419 Finished ✅ Results

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 9cf67348-acdf-4e7c-89a4-f93c42396775

📥 Commits

Reviewing files that changed from the base of the PR and between e9f39a1 and 97a61d2.

📒 Files selected for processing (2)
  • frontend/web/components/pages/IdentityPage.tsx
  • frontend/web/components/pages/features/FeaturesPage.tsx

Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

TryIt now requires at least three total features before it renders when the try_it flag is enabled. E2E mode bypasses this threshold. IdentityPage and FeaturesPage provide feature counts from live pagination data and cached project totals. FeaturesSDKIntegration accepts and forwards the optional totalFeatures prop.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 97a61

The dashboard now hides “Try it out” until a project has at least three flags, while preserving the existing behavior otherwise. No actionable merge-blocking risk remains after normal checks and review.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #19977 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  41.4 seconds
commit  97a61d2
info  🔄 Run: #19977 (attempt 1)

🗂️ Previous results
✅ private-cloud · depot-ubuntu-latest-16 — run #19977 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  32.2 seconds
commit  97a61d2
info  🔄 Run: #19977 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #19977 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  39.1 seconds
commit  97a61d2
info  🔄 Run: #19977 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #19977 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  41.7 seconds
commit  97a61d2
info  🔄 Run: #19977 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #19973 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  38.1 seconds
commit  e9f39a1
info  🔄 Run: #19973 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #19973 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  41.9 seconds
commit  e9f39a1
info  🔄 Run: #19973 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #19973 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  51.2 seconds
commit  e9f39a1
info  🔄 Run: #19973 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #19973 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  33.6 seconds
commit  e9f39a1
info  🔄 Run: #19973 (attempt 1)

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4c8cf031-9722-4486-a4f9-f33b4f9eaa03

📥 Commits

Reviewing files that changed from the base of the PR and between 8044b6d and e9f39a1.

📒 Files selected for processing (4)
  • frontend/web/components/TryIt.js
  • frontend/web/components/pages/IdentityPage.tsx
  • frontend/web/components/pages/features/FeaturesPage.tsx
  • frontend/web/components/pages/features/components/FeaturesSDKIntegration.tsx

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Comment thread frontend/web/components/pages/features/FeaturesPage.tsx Outdated
@Zaimwa9
Zaimwa9 merged commit 50e0309 into main Aug 31, 2026
31 checks passed
@Zaimwa9
Zaimwa9 deleted the fix/gate-try-it-min-flags branch August 31, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants