Skip to content

fix: move custom fields to org settings #5163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tiagoapolo merged 3 commits into from
Apr 24, 2025
Merged

fix: move custom fields to org settings #5163

tiagoapolo merged 3 commits into from
Apr 24, 2025

Conversation

@tiagoapolo
Copy link
Contributor

@tiagoapolo tiagoapolo commented Feb 27, 2025 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Ref: #4384

  • Moving custom fields config to org settings because they are org level changes
  • object_id needs to be removed because when a field is set as required it's set at org level configuration, we don't need to specify the project id

How did you test this code?

Please describe.

@vercel
Copy link

vercel bot commented Feb 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 6:12pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 6:12pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2025 6:12pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Feb 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2025 •
edited
Loading

Uffizzi Preview deployment-63062 was deleted.

@tiagoapolo tiagoapolo self-assigned this Feb 27, 2025
@github-actions github-actions bot added fix and removed fix labels Feb 27, 2025
@tiagoapolo tiagoapolo force-pushed the fix/move-custom-fields-4384 branch from c31aa56 to bb04d70 Compare April 23, 2025 18:22
@tiagoapolo tiagoapolo marked this pull request as ready for review April 23, 2025 18:22
@tiagoapolo tiagoapolo requested a review from a team as a code owner April 23, 2025 18:22
@tiagoapolo tiagoapolo requested review from Zaimwa9 and removed request for a team April 23, 2025 18:22
@github-actions github-actions bot added fix and removed fix labels Apr 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2025 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5163 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5163 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5163 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-5163 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5163 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-5163 Finished ✅ Results ✅

matthewelwell
matthewelwell reviewed Apr 23, 2025
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me from a code perspective, but I wonder if there's a way that we can redirect any users that are expecting to navigate to the custom fields tab in the project settings to the organisation settings?

@tiagoapolo
Copy link
Contributor Author

tiagoapolo commented Apr 24, 2025

but I wonder if there's a way that we can redirect any users that are expecting to navigate to the custom fields tab in the project settings to the organisation settings?

Sure thing!

@github-actions github-actions bot added fix and removed fix labels Apr 24, 2025
@tiagoapolo
Copy link
Contributor Author

tiagoapolo commented Apr 24, 2025

but I wonder if there's a way that we can redirect any users that are expecting to navigate to the custom fields tab in the project settings to the organisation settings?

Sure thing!

Screenshot 2025-04-24 at 14 02 49

matthewelwell
matthewelwell approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. I've added a small suggestion for the copy of the relocation warning.

Zaimwa9
Zaimwa9 approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@Zaimwa9 Zaimwa9 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved after committing suggestion 👏

@tiagoapolo @matthewelwell
Update frontend/web/components/pages/ProjectSettingsPage.js
942700d 
Co-authored-by: Matthew Elwell <matthew.elwell@flagsmith.com>
@github-actions github-actions bot added fix and removed fix labels Apr 24, 2025
@tiagoapolo tiagoapolo merged commit ea4db70 into main Apr 24, 2025
34 checks passed
@tiagoapolo tiagoapolo deleted the fix/move-custom-fields-4384 branch April 24, 2025 18:31
@flagsmithdev flagsmithdev mentioned this pull request Apr 24, 2025
Merged
@Zaimwa9 Zaimwa9 mentioned this pull request Jun 2, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emyller emyller emyller approved these changes

@matthewelwell matthewelwell matthewelwell approved these changes

@Zaimwa9 Zaimwa9 Zaimwa9 approved these changes

Assignees

@tiagoapolo tiagoapolo

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tiagoapolo @emyller @matthewelwell @Zaimwa9