Skip to content

chore: drop Python 2 support#5315

Merged
khvn26 merged 1 commit intomainfrom
chore/drop-python-2-support
Apr 8, 2025
Merged

chore: drop Python 2 support#5315
khvn26 merged 1 commit intomainfrom
chore/drop-python-2-support

Conversation

@khvn26
Copy link
Copy Markdown
Member

@khvn26 khvn26 commented Apr 8, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This removes an unused code path in settings/common.py.

How did you test this code?

Green CI will mean ok to merge as it's common settings.

@khvn26 khvn26 requested a review from a team as a code owner April 8, 2025 19:40
@khvn26 khvn26 requested review from Zaimwa9 and removed request for a team April 8, 2025 19:40
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Apr 8, 2025 7:40pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Apr 8, 2025 7:40pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Apr 8, 2025 7:40pm

@github-actions github-actions Bot added api Issue related to the REST API chore labels Apr 8, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5315 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5315 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5315 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5315 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5315 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5315 Finished ✅ Results

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2025

Uffizzi Preview deployment-62574 was deleted.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.52%. Comparing base (374a5f4) to head (ab26b29).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5315   +/-   ##
=======================================
  Coverage   97.52%   97.52%           
=======================================
  Files        1226     1226           
  Lines       42564    42559    -5     
=======================================
- Hits        41510    41507    -3     
+ Misses       1054     1052    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@khvn26 khvn26 merged commit 8fa9cb9 into main Apr 8, 2025
37 checks passed
@khvn26 khvn26 deleted the chore/drop-python-2-support branch April 8, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants