Skip to content

fix: Handles trailing space in flag value#5324

Merged
tiagoapolo merged 1 commit intomainfrom
fix/trailing-space--5290
Apr 10, 2025
Merged

fix: Handles trailing space in flag value#5324
tiagoapolo merged 1 commit intomainfrom
fix/trailing-space--5290

Conversation

@tiagoapolo
Copy link
Copy Markdown
Contributor

@tiagoapolo tiagoapolo commented Apr 9, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Ref: #5290

  • Trims trailing spaces in flag value string
  • Adds e2e test case for trailing spaces handling

How did you test this code?

https://www.loom.com/share/e2ecca7ab79b407fbbb7b6419fbd6c5d?sid=d952df2b-dd74-41be-ae8e-7fc0169a2424

@tiagoapolo tiagoapolo requested a review from a team as a code owner April 9, 2025 15:43
@tiagoapolo tiagoapolo requested review from kyle-ssg and removed request for a team April 9, 2025 15:43
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2025 2:56pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2025 2:56pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Apr 10, 2025 2:56pm

@github-actions github-actions Bot added front-end Issue related to the React Front End Dashboard fix labels Apr 9, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5324 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5324 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5324 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5324 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5324 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5324 Finished ✅ Results

@tiagoapolo tiagoapolo requested a review from Zaimwa9 April 9, 2025 15:43
@tiagoapolo tiagoapolo self-assigned this Apr 9, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2025

Uffizzi Preview deployment-62626 was deleted.

Comment thread frontend/web/components/modals/CreateFlag.js Outdated
remove comment

comment test

revert test changes

initial_value can be a number

remove comments
@tiagoapolo tiagoapolo force-pushed the fix/trailing-space--5290 branch from 3fdaed4 to 72ff433 Compare April 10, 2025 14:53
@github-actions github-actions Bot added fix and removed fix labels Apr 10, 2025
@tiagoapolo tiagoapolo merged commit de1c66a into main Apr 10, 2025
33 checks passed
@tiagoapolo tiagoapolo deleted the fix/trailing-space--5290 branch April 10, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants