-
Notifications
You must be signed in to change notification settings - Fork 466
feat: MetadataModelRequirement uses organisation ID as objectID (✅ relies on #5325 - deployed) #5326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: MetadataModelRequirement uses organisation ID as objectID (✅ relies on #5325 - deployed) #5326
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Docker builds report
|
|
Uffizzi Preview |
…b.com:Flagsmith/flagsmith into feat/remove-usage-of-required-for-object-id-in-metadata
for more information, see https://pre-commit.ci
…b.com:Flagsmith/flagsmith into feat/metadata-requirements-object-id-optional
…b.com:Flagsmith/flagsmith into feat/remove-usage-of-required-for-object-id-in-metadata
…b.com:Flagsmith/flagsmith into feat/remove-usage-of-required-for-object-id-in-metadata
…b.com:Flagsmith/flagsmith into feat/remove-usage-of-required-for-object-id-in-metadata
|
Great! 🎉 |
tiagoapolo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a suggestion but overall looks good to me and I'm aligned with that approach.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5326 +/- ##
=======================================
Coverage 97.61% 97.61%
=======================================
Files 1237 1237
Lines 42971 42972 +1
=======================================
+ Hits 41948 41949 +1
Misses 1023 1023 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Related to issue #5167
@tiagoapolo , following discussion with @kyle-ssg , we went for an in-between solution so that the required_for points to an organization while leaving the project implementation open for later. In this case it makes to relate the
required_forfield to the given organisation. Let me know your thoughtscontent_typeinrequired_forobject_idHow did you test this code?
https://www.loom.com/share/f17075de90744c64bc64554629ed3eca
Additional considerations
There are some points to keep in mind in the current metadata fields implementation. Just listing and depending on prio because quite some refacto.
As of Fields and Model fields are fetched with 2 different requests
GET /fieldsandGET /metadata-model-fieldsthen reconciliated in the frontend (MetadataPage) and it brings several problems long term:create metadata field -> invalidated GET list -> create metadata model field -> invalidated GET list, it could be reduced imo