feat(billing): Remove AUTO_SEAT_UPGRADE_PLANS setting#5343
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
|
Uffizzi Preview |
e78d116 to
aa39204
Compare
d5393d8 to
1271758
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5343 +/- ##
=======================================
Coverage 97.61% 97.61%
=======================================
Files 1237 1237
Lines 42918 42968 +50
=======================================
+ Hits 41894 41945 +51
+ Misses 1024 1023 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| return self.plan in settings.AUTO_SEAT_UPGRADE_PLANS | ||
| return ( | ||
| is_saas() | ||
| and self.subscription_plan_family == SubscriptionPlanFamily.SCALE_UP |
There was a problem hiding this comment.
So i'm seeing
class SubscriptionPlanFamily(Enum):
FREE = "FREE"
START_UP = "START_UP"
SCALE_UP = "SCALE_UP"
ENTERPRISE = "ENTERPRISE"
But I don't see the plan on the pricing page. Is it a custom in between start-up and enterprise?
There was a problem hiding this comment.
Good question 👍 Our plan lineup has been revised to exclude scale-up for new customers, but we still support existing scale-up users.
Zaimwa9
left a comment
There was a problem hiding this comment.
The tests seem to cover the different cases. If I summarize how we do now:
If subscription is scale-up-xx
Organisation don't have fixed user limits but when adding a new one:
- We charge the seat
- if payment fails => failure and user can't join
- otherwise +1 user ?
Could you let me know when it's on staging to use it to start manipulating chargebee 👍 ?
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
In this PR, we remove the
AUTO_SEAT_UPGRADE_PLANSsetting in favour of centralisedSubscriptionPlanFamily.get_by_plan_idlogic.How did you test this code?
Made sure all relevant unit tests pass without the setting present.