fix: metadata inputs not updating values #5372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Zaimwa9
requested review from
khvn26 and
kyle-ssg
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
github-actions
bot
added
front-end
Contributor
Docker builds report
|
for more information, see https://pre-commit.ci
Contributor
|
Uffizzi Preview |
Zaimwa9
changed the base branch from
main
to
fix/update-metadata-value-from-entity
tiagoapolo
reviewed
Apr 23, 2025
Co-authored-by: Tiago Paiva <tiago@tiagopaiva.me>
…-metadata-value-from-entity
github-actions
bot
added
fix
and removed
fix
infrastructure
docs
emyller
approved these changes
May 5, 2025
api/environments/serializers.py
Outdated
| environment = super().update(instance, validated_data) # type: ignore[no-untyped-call] | ||
| self.update_metadata(environment, metadata_items) | ||
| environment.refresh_from_db() | ||
| assert isinstance(environment, Environment) |
Contributor
There was a problem hiding this comment.
Is this needed? Not a blocker.
Contributor
Author
There was a problem hiding this comment.
Not needed per say but mypy is a tough opponent and it would require unrelated typing that I think is overkill in the context of a bug fix
Contributor
There was a problem hiding this comment.
Fairy nuff. Let me know if you need help swinging a few punches.
Member
There was a problem hiding this comment.
FWIW, the issue is tracked Flagsmith/flagsmith-common#71.
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5372 +/- ##
==========================================
+ Coverage 97.62% 97.63% +0.01%
==========================================
Files 1238 1239 +1
Lines 43000 43097 +97
==========================================
+ Hits 41977 42078 +101
+ Misses 1023 1019 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
khvn26
approved these changes
May 8, 2025
api/environments/serializers.py
Outdated
| environment = super().update(instance, validated_data) # type: ignore[no-untyped-call] | ||
| self.update_metadata(environment, metadata_items) | ||
| environment.refresh_from_db() | ||
| assert isinstance(environment, Environment) |
Member
There was a problem hiding this comment.
FWIW, the issue is tracked Flagsmith/flagsmith-common#71.
…ta-inputs-not-updating-value
Zaimwa9
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Metadata fields inputs could stay stuck on non up to date values
envDatadependency in AddMetadataToEntity useEffectHow did you test this code?
https://www.loom.com/share/f980f034f6144c548a2f30efd809f828