-
Notifications
You must be signed in to change notification settings - Fork 466
feat: Inspect Permissions #5375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
51789dd to
587305e
Compare
Uffizzi Ephemeral Environment Deploying☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5375 ⚙️ Updating now by workflow run 15124619466. What is Uffizzi? Learn more! |
587305e to
4fc81ad
Compare
Docker builds report
|
|
Created this branch including backend for testing purposes if needed |
Zaimwa9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments. Nothing critical (although one in the backend), working really well besides that.
I just have a question. I'm not sure to get what's the difference between GRANTED, GRANTED_FOR_TAGS
if a user has a role with GRANTED_FOR_TAGS for DELETE_FEATURE and the role specifies certain tags, they will only be able to delete features that have at least one of those specified tags. Features without any of the specified tags will be protected from deletion by that user. |
| }} | ||
| /> | ||
| )} | ||
| {showDerivedPermissions && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's more of a product question but I wonder whether we should show that the user has the permission granted both directly and through derived permissions.
Let's say you want to remove create project from me. You would remove it directly from my user permissions without knowing that I will still have it from a role I have but wasn't shown no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already support that, but we don't show a tooltip text when is a directly assigned permission + derived, but I could add a copy text for that specific case.
Zaimwa9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! Really nice feature, ready to go imo once backend released (and a couple of conflicts to solve)
wip wip
fix logic adds more mocked data
e75b94b to
7953089
Compare
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Ref: #5064
How did you test this code?