chore: show deleted organisations in sales dashboard#5390
Merged
matthewelwell merged 3 commits intomainfrom Apr 25, 2025
Merged
chore: show deleted organisations in sales dashboard#5390matthewelwell merged 3 commits intomainfrom
matthewelwell merged 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Contributor
Docker builds report
|
Contributor
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5390 +/- ##
=======================================
Coverage 97.61% 97.61%
=======================================
Files 1237 1237
Lines 42975 42979 +4
=======================================
+ Hits 41952 41956 +4
Misses 1023 1023 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
[ ] I have added information todocs/if required so people know about the feature!Changes
The main purpose of this PR was to add the ability to show deleted organisations in the sales dashboard. Since I was already working in the area, I also tried to tackle something that has been bothering me for a while, which is the performance of the sales dashboard. As such, I tried to optimise the annotations to only annotate the queryset with any annotation that was needed for sorting (as you can see here) but this didn't actually change anything due to the behaviour of django's lazily evaluated querysets. Without diving deeper into the pagination logic, I'm not sure there's an option here to optimise the queries that are needed.
How did you test this code?
Validated the 'include deleted' logic locally when running the API.