Skip to content

fix: return-empty-trait-list-if-persistence-not-allowed-from-sdk#5399

Merged
Zaimwa9 merged 7 commits intomainfrom
fix/return-empty-traits-list-if-trait-persistence-not-allowed
Apr 30, 2025
Merged

fix: return-empty-trait-list-if-persistence-not-allowed-from-sdk#5399
Zaimwa9 merged 7 commits intomainfrom
fix/return-empty-traits-list-if-trait-persistence-not-allowed

Conversation

@Zaimwa9
Copy link
Copy Markdown
Contributor

@Zaimwa9 Zaimwa9 commented Apr 29, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Validate returns empty traits list

How did you test this code?

  • Added tests

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner April 29, 2025 08:06
@Zaimwa9 Zaimwa9 requested review from gagantrivedi and removed request for a team April 29, 2025 08:06
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2025 11:43am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2025 11:43am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2025 11:43am

@sentry
Copy link
Copy Markdown

sentry Bot commented Apr 29, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: api/environments/sdk/serializers.py

Function Unhandled Issue
save ValueError: Cannot compare feature states as they are missing environment_feature_version. ...
Event Count: 4

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions Bot added api Issue related to the REST API fix labels Apr 29, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5399 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5399 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5399 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5399 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5399 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5399 Finished ✅ Results

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2025

Uffizzi Ephemeral Environment deployment-63255

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5399

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2025

Uffizzi Preview deployment-63255 was deleted.

Zaimwa9 added 2 commits April 29, 2025 10:35
…llowed' of github.com:Flagsmith/flagsmith into fix/return-empty-traits-list-if-trait-persistence-not-allowed
@github-actions github-actions Bot added fix and removed fix labels Apr 29, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.62%. Comparing base (0cfe793) to head (0bbb04c).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5399   +/-   ##
=======================================
  Coverage   97.62%   97.62%           
=======================================
  Files        1238     1238           
  Lines       43000    43031   +31     
=======================================
+ Hits        41977    42008   +31     
  Misses       1023     1023           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rolodato rolodato requested review from a team as code owners April 29, 2025 11:41
@rolodato rolodato requested review from tiagoapolo and removed request for a team April 29, 2025 11:41
@github-actions github-actions Bot added front-end Issue related to the React Front End Dashboard docs Documentation updates fix and removed fix docs Documentation updates labels Apr 29, 2025
@Zaimwa9 Zaimwa9 merged commit 19cd637 into main Apr 30, 2025
39 checks passed
@Zaimwa9 Zaimwa9 deleted the fix/return-empty-traits-list-if-trait-persistence-not-allowed branch April 30, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants