-
Notifications
You must be signed in to change notification settings - Fork 466
feat: Render usage report in sales dashboard usage directly, without sending email #5407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5407 +/- ##
==========================================
+ Coverage 97.62% 97.63% +0.01%
==========================================
Files 1238 1239 +1
Lines 43037 43065 +28
==========================================
+ Hits 42014 42046 +32
+ Misses 1023 1019 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
matthewelwell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy for you to add # pragma: no cover where needed if it's easier than writing tests to cover the view.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Previously, we were requiring users to enter an email address so that they could receive these reports:
This is not ideal for several reasons:
This change also intentionally breaks the
/sales-dashboard/email-usageroute by renaming it to/sales-dashboard/usage. It is extremely unlikely that this will actually break anyone's links, considering it's not a documented route and this route would be used ~2x a year at most.Alternatives considered
If we really want to keep emails for some reason, we could have a plain-text report be sent directly from the client, by using a
mailtolink from the same HTML-rendered report. I decided to keep HTML only for simplicity.How did you test this code?
Manually by browsing to
/sales-dashboard/usageon any API instance.