fix(e2e): Incorrect project selected in RBAC E2E on staging#5433
Merged
fix(e2e): Incorrect project selected in RBAC E2E on staging#5433
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Contributor
Docker builds report
|
Contributor
Uffizzi Ephemeral Environment Deploying☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5433 ⚙️ Updating now by workflow run 14907305716. What is Uffizzi? Learn more! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5433 +/- ##
==========================================
- Coverage 97.63% 97.63% -0.01%
==========================================
Files 1239 1234 -5
Lines 43065 42960 -105
==========================================
- Hits 42046 41942 -104
+ Misses 1019 1018 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
Bot
added
front-end
khvn26
approved these changes
May 8, 2025
Member
There was a problem hiding this comment.
Can see the latest staging E2E run is green so 👍
One minor comment related to rbac model relations having on_delete=CASCADE.
Comment on lines
+40
to
+44
| if settings.IS_RBAC_INSTALLED: | ||
| from rbac.models import Role # type: ignore[import-not-found,unused-ignore] | ||
|
|
||
| for org in user.organisations.all(): | ||
| Role.objects.filter(organisation=org).delete() |
Contributor
Author
There was a problem hiding this comment.
Ah thanks, was just pushing the removal
khvn26
changed the title
khvn26
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
When testing for roles in e2e, the project is selected by index. An incorrect project is selected on staging. The PR implements a correct
test-data-based selector.How did you test this code?
In CI + locally