Skip to content

feat: Add make shortcut to run both API and worker#5565

Merged
emyller merged 6 commits intomainfrom
feat/run-api-with-worker
Jun 12, 2025
Merged

feat: Add make shortcut to run both API and worker#5565
emyller merged 6 commits intomainfrom
feat/run-api-with-worker

Conversation

@emyller
Copy link
Copy Markdown
Contributor

@emyller emyller commented Jun 11, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Introduce make serve-with-task-processor as a shortcut to run the API + asynchronous task processor in the local environment.

How did you test this code?

Relying on this command for the past few weeks.

@emyller emyller self-assigned this Jun 11, 2025
@emyller emyller requested review from a team as code owners June 11, 2025 16:22
@emyller emyller requested review from khvn26 and removed request for a team June 11, 2025 16:22
@github-actions github-actions bot added api Issue related to the REST API docs Documentation updates labels Jun 11, 2025
@vercel
Copy link
Copy Markdown

vercel bot commented Jun 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2025 6:10pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2025 6:10pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2025 6:10pm

@github-actions github-actions bot added feature New feature or request and removed docs Documentation updates labels Jun 11, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 11, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5565 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5565 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-5565 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-5565 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5565 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5565 Finished ✅ Results

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (8ebf949) to head (043a101).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5565   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files        1247     1247           
  Lines       44249    44249           
=======================================
  Hits        43231    43231           
  Misses       1018     1018           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one thanks, works as a charm

Copy link
Copy Markdown
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep formatting changes out of this PR, if possible.

@emyller
Copy link
Copy Markdown
Contributor Author

emyller commented Jun 11, 2025

I'd like to keep formatting changes out of this PR, if possible.

This is what the linter led to while editing this file. I will force-revert it.

Co-authored-by: Kim Gustyr <kim.gustyr@flagsmith.com>
@github-actions github-actions bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Jun 11, 2025
@github-actions github-actions bot added docs Documentation updates and removed feature New feature or request labels Jun 11, 2025
@github-actions github-actions bot added feature New feature or request and removed docs Documentation updates labels Jun 11, 2025
@github-actions github-actions bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Jun 11, 2025
@emyller emyller merged commit c1eed05 into main Jun 12, 2025
31 checks passed
@emyller emyller deleted the feat/run-api-with-worker branch June 12, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants