Skip to content

fix: deduplicate metrics live features states#5571

Merged
Zaimwa9 merged 3 commits intomainfrom
fix/deduplicate-metrics-live-features-states
Jun 17, 2025
Merged

fix: deduplicate metrics live features states#5571
Zaimwa9 merged 3 commits intomainfrom
fix/deduplicate-metrics-live-features-states

Conversation

@Zaimwa9
Copy link
Contributor

@Zaimwa9 Zaimwa9 commented Jun 16, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Reported metrics were incorrect on long-lived environment (with feature-versioning). This PR deduplicates the feature-states from the feature (Total features/Features enabled/Segment override) and adapted identity_overrides count with dynamoDB

How did you test this code?

  • Added tests
  • Tested SQL queries against prod to eliminate duplication

@Zaimwa9 Zaimwa9 requested a review from gagantrivedi June 16, 2025 14:58
@Zaimwa9 Zaimwa9 requested a review from a team as a code owner June 16, 2025 14:58
@vercel
Copy link

vercel bot commented Jun 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jun 16, 2025 2:58pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Jun 16, 2025 2:58pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Jun 16, 2025 2:58pm

@github-actions github-actions bot added api Issue related to the REST API fix labels Jun 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5571 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5571 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-5571 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-5571 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5571 Finished ✅ Results

@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (68f6847) to head (319c290).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5571      +/-   ##
==========================================
- Coverage   97.70%   97.69%   -0.01%     
==========================================
  Files        1248     1248              
  Lines       44270    44287      +17     
==========================================
+ Hits        43252    43268      +16     
- Misses       1018     1019       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Zaimwa9 Zaimwa9 merged commit 7cb3758 into main Jun 17, 2025
30 checks passed
@Zaimwa9 Zaimwa9 deleted the fix/deduplicate-metrics-live-features-states branch June 17, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants